Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
Update QScintilla CMake find module to handle new lib name in 2.10
[ci skip]
- Loading branch information
b1c653b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only does half the job. The names changed for Qt4 as well.
b1c653b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Scimmia22, thanks for pointing that out; though, adding that support here for QGIS 3 is unnecessary, since Qt4 is deprecated and not used. However, the backports to QGIS 2.14/2.18 should have that added.
b1c653b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in beb55d1 and 3057738.
b1c653b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Funnily enough, I meant this comment to be on the commit in the 2.18 branch. No idea how I ended up here. :)
Thanks for taking care of it.