Navigation Menu

Skip to content

Commit

Permalink
Remove cryptic assert (was failing regularly)
Browse files Browse the repository at this point in the history
  • Loading branch information
@nyalldawson
nyalldawson committed Apr 21, 2016
1 parent eacca44 commit b1b439f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/core/qgsrulebasedlabeling.cpp
View file
Expand Up @@ -266,8 +266,6 @@ QgsRuleBasedLabeling::Rule::RegisterResult QgsRuleBasedLabeling::Rule::registerF

bool registered = false;

Q_ASSERT( !mSettings == subProviders.contains( this ) );

// do we have active subprovider for the rule?
if ( subProviders.contains( this ) && mIsActive )
{
Expand Down

2 comments on commit b1b439f

@nyalldawson
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jef-n Can you explain what the intention with this assert was? (we only allow either mSettings or having the subProvider containing this but not both?) It consistently trips up the labeling unit tests.

@lcoandrade
Copy link

@lcoandrade lcoandrade commented on b1b439f Aug 10, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When will this be available for QGIS 2.14 LTR? Thanks for fixing this!!!

Please sign in to comment.