Enabled changing attribute values for OGR Layers

mhugent · mhugent · commit b1233721c6c4 · 2006-08-18T13:42:14.000Z
git-svn-id: http://svn.osgeo.org/qgis/trunk/qgis@5709 c8812cc2-4d05-0410-92ff-de0c093fc19c
diff --git a/src/gui/qgsattributetable.cpp b/src/gui/qgsattributetable.cpp
@@ -142,7 +142,6 @@ void QgsAttributeTable::handleChangedSelections()
   //don't send the signal repaintRequested() from here
   //but in contentsMouseReleaseEvent() and rowClicked(int)
   //todo: don't repaint in case of double clicks
-
 }
 
 void QgsAttributeTable::insertFeatureId(int id, int row)
diff --git a/src/providers/ogr/qgsogrprovider.cpp b/src/providers/ogr/qgsogrprovider.cpp
@@ -1254,9 +1254,6 @@ int QgsOgrProvider::capabilities() const
       ability |= DeleteFeatures;
     }
     
-    //seems to work with newer ogr versions
-    //ability |= ChangeAttributeValues;
-    
     if (ogrLayer->TestCapability("RandomWrite"))
     // TRUE if the SetFeature() method is operational on this layer.
     {
@@ -1265,6 +1262,7 @@ int QgsOgrProvider::capabilities() const
       // TODO Need to work out versions of shapelib vs versions of GDAL/OGR
       // TODO And test appropriately.
 
+      ability |= ChangeAttributeValues;
       // This provider can't change geometries yet anyway (cf. Postgres provider)
       // ability |= QgsVectorDataProvider::ChangeGeometries;
     }

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,6 @@ void QgsAttributeTable::handleChangedSelections()`
`142`	`142`	`//don't send the signal repaintRequested() from here`
`143`	`143`	`//but in contentsMouseReleaseEvent() and rowClicked(int)`
`144`	`144`	`//todo: don't repaint in case of double clicks`
`145`		`-`
`146`	`145`	`}`
`147`	`146`
`148`	`147`	`void QgsAttributeTable::insertFeatureId(int id, int row)`
Original file line number	Diff line number	Diff line change
`@@ -1254,9 +1254,6 @@ int QgsOgrProvider::capabilities() const`
`1254`	`1254`	`ability \|= DeleteFeatures;`
`1255`	`1255`	`}`
`1256`	`1256`
`1257`		`- //seems to work with newer ogr versions`
`1258`		`- //ability \|= ChangeAttributeValues;`
`1259`		`-`
`1260`	`1257`	`if (ogrLayer->TestCapability("RandomWrite"))`
`1261`	`1258`	`// TRUE if the SetFeature() method is operational on this layer.`
`1262`	`1259`	`{`
`@@ -1265,6 +1262,7 @@ int QgsOgrProvider::capabilities() const`
`1265`	`1262`	`// TODO Need to work out versions of shapelib vs versions of GDAL/OGR`
`1266`	`1263`	`// TODO And test appropriately.`
`1267`	`1264`
	`1265`	`+ ability \|= ChangeAttributeValues;`
`1268`	`1266`	`// This provider can't change geometries yet anyway (cf. Postgres provider)`
`1269`	`1267`	`// ability \|= QgsVectorDataProvider::ChangeGeometries;`
`1270`	`1268`	`}`