[processing] Don't raise uncaught exceptions when trying to generate

nyalldawson · nyalldawson · commit b00a04c152f1 · 2023-02-27T12:15:34.000+10:00
GDAL commands for invalid layers This is a partial fix, which at least removes the uncaught exception. Ideally we'd gracefully fall back to using the layer's source (even if it doesn't exist!) in the generated GDAL commands. But that's far from trivial to do. Fixes #51958
diff --git a/python/plugins/processing/algs/gdal/GdalAlgorithmDialog.py b/python/plugins/processing/algs/gdal/GdalAlgorithmDialog.py
@@ -33,8 +33,11 @@
                                  QSizePolicy,
                                  QDialogButtonBox)
 
-from qgis.core import (QgsProcessingFeedback,
-                       QgsProcessingParameterDefinition)
+from qgis.core import (
+    QgsProcessingException,
+    QgsProcessingFeedback,
+    QgsProcessingParameterDefinition
+)
 from qgis.gui import (QgsMessageBar,
                       QgsProjectionSelectionWidget,
                       QgsProcessingAlgorithmDialogBase,
@@ -140,9 +143,12 @@ def parametersHaveChanged(self):
                     self.text.setPlainText('')
                     return
 
-            commands = self.algorithm().getConsoleCommands(parameters, context, feedback, executing=False)
-            commands = [c for c in commands if c not in ['cmd.exe', '/C ']]
-            self.text.setPlainText(" ".join(commands))
+            try:
+                commands = self.algorithm().getConsoleCommands(parameters, context, feedback, executing=False)
+                commands = [c for c in commands if c not in ['cmd.exe', '/C ']]
+                self.text.setPlainText(" ".join(commands))
+            except QgsProcessingException as e:
+                self.text.setPlainText(str(e))
         except AlgorithmDialogBase.InvalidParameterValue as e:
             self.text.setPlainText(self.tr("Invalid value for parameter '{0}'").format(e.parameter.description()))
         except AlgorithmDialogBase.InvalidOutputExtension as e:
