[:)] Make a developer happy

elpaso · elpaso · commit afecc2101299 · 2017-10-03T16:34:50.000+02:00
diff --git a/src/providers/wms/qgstilecache.cpp b/src/providers/wms/qgstilecache.cpp
@@ -33,10 +33,11 @@ void QgsTileCache::insertTile( const QUrl &url, const QImage &image )
 bool QgsTileCache::tile( const QUrl &url, QImage &image )
 {
   QMutexLocker locker( &sTileCacheMutex );
+  bool success = false;
   if ( QImage *i = sTileCache.object( url ) )
   {
     image = *i;
-    return true;
+    success = true;
   }
   else if ( QgsNetworkAccessManager::instance()->cache()->metaData( url ).isValid() )
   {
@@ -52,9 +53,9 @@ bool QgsTileCache::tile( const QUrl &url, QImage &image )
       if ( ! image.isNull( ) )
       {
         sTileCache.insert( url, new QImage( image ) );
-        return true;
+        success = true;
       }
     }
   }
-  return false;
+  return success;
 }

Original file line number	Diff line number	Diff line change
`@@ -33,10 +33,11 @@ void QgsTileCache::insertTile( const QUrl &url, const QImage &image )`
`33`	`33`	`bool QgsTileCache::tile( const QUrl &url, QImage &image )`
`34`	`34`	`{`
`35`	`35`	`QMutexLocker locker( &sTileCacheMutex );`
	`36`	`+ bool success = false;`
`36`	`37`	`if ( QImage *i = sTileCache.object( url ) )`
`37`	`38`	`{`
`38`	`39`	`image = *i;`
`39`		`- return true;`
	`40`	`+ success = true;`
`40`	`41`	`}`
`41`	`42`	`else if ( QgsNetworkAccessManager::instance()->cache()->metaData( url ).isValid() )`
`42`	`43`	`{`
`@@ -52,9 +53,9 @@ bool QgsTileCache::tile( const QUrl &url, QImage &image )`
`52`	`53`	`if ( ! image.isNull( ) )`
`53`	`54`	`{`
`54`	`55`	`sTileCache.insert( url, new QImage( image ) );`
`55`		`- return true;`
	`56`	`+ success = true;`
`56`	`57`	`}`
`57`	`58`	`}`
`58`	`59`	`}`
`59`		`- return false;`
	`60`	`+ return success;`
`60`	`61`	`}`