Fix potential crash when calling QgsCircularString::pointN with bad

nyalldawson · nyalldawson · commit afcb82efe769 · 2017-09-19T17:22:33.000+10:00
index
diff --git a/src/core/geometry/qgscircularstring.cpp b/src/core/geometry/qgscircularstring.cpp
@@ -389,7 +389,7 @@ int QgsCircularString::numPoints() const
 
 QgsPoint QgsCircularString::pointN( int i ) const
 {
-  if ( std::min( mX.size(), mY.size() ) <= i )
+  if ( i < 0 || std::min( mX.size(), mY.size() ) <= i )
   {
     return QgsPoint();
   }

Original file line number	Diff line number	Diff line change
`@@ -389,7 +389,7 @@ int QgsCircularString::numPoints() const`
`389`	`389`
`390`	`390`	`QgsPoint QgsCircularString::pointN( int i ) const`
`391`	`391`	`{`
`392`		`- if ( std::min( mX.size(), mY.size() ) <= i )`
	`392`	`+ if ( i < 0 \|\| std::min( mX.size(), mY.size() ) <= i )`
`393`	`393`	`{`
`394`	`394`	`return QgsPoint();`
`395`	`395`	`}`