Fix cast warnings

elpaso · elpaso · commit ae91fb288ff3 · 2019-06-24T12:11:51.000+02:00
diff --git a/src/app/gps/qgsgpsinformationwidget.cpp b/src/app/gps/qgsgpsinformationwidget.cpp
@@ -1021,11 +1021,11 @@ void QgsGpsInformationWidget::mBtnCloseFeature_clicked()
 
     if ( layerWKBType == QgsWkbTypes::LineString )
     {
-      int size = 1 + 2 * sizeof( int ) + 2 * mCaptureList.size() * sizeof( double );
+      int size = 1 + 2 *  static_cast<int>( sizeof( int ) ) + 2 * mCaptureList.size() * static_cast<int>( sizeof( double ) );
       unsigned char *buf = new unsigned char[size];
 
       QgsWkbPtr wkbPtr( buf, size );
-      wkbPtr << ( char ) QgsApplication::endian() << QgsWkbTypes::LineString << mCaptureList.size();
+      wkbPtr << static_cast< char >( QgsApplication::endian() ) << QgsWkbTypes::LineString << mCaptureList.size();
 
       for ( QList<QgsPointXY>::const_iterator it = mCaptureList.constBegin(); it != mCaptureList.constEnd(); ++it )
       {
@@ -1043,11 +1043,11 @@ void QgsGpsInformationWidget::mBtnCloseFeature_clicked()
     }
     else if ( layerWKBType == QgsWkbTypes::Polygon )
     {
-      int size = 1 + 3 * sizeof( int ) + 2 * ( mCaptureList.size() + 1 ) * sizeof( double );
+      int size = 1 + 3 * static_cast< int >( sizeof( int ) ) + 2 * ( mCaptureList.size() + 1 ) * static_cast< int >( sizeof( double ) );
       unsigned char *buf = new unsigned char[size];
 
       QgsWkbPtr wkbPtr( buf, size );
-      wkbPtr << ( char ) QgsApplication::endian() << QgsWkbTypes::Polygon << 1 << mCaptureList.size() + 1;
+      wkbPtr << static_cast< char >( QgsApplication::endian() ) << QgsWkbTypes::Polygon << 1 << mCaptureList.size() + 1;
 
       QList<QgsPointXY>::iterator it;
       for ( it = mCaptureList.begin(); it != mCaptureList.end(); ++it )

Original file line number	Diff line number	Diff line change
`@@ -1021,11 +1021,11 @@ void QgsGpsInformationWidget::mBtnCloseFeature_clicked()`
`1021`	`1021`
`1022`	`1022`	`if ( layerWKBType == QgsWkbTypes::LineString )`
`1023`	`1023`	`{`
`1024`		`- int size = 1 + 2 * sizeof( int ) + 2 * mCaptureList.size() * sizeof( double );`
	`1024`	`+ int size = 1 + 2 * static_cast<int>( sizeof( int ) ) + 2 * mCaptureList.size() * static_cast<int>( sizeof( double ) );`
`1025`	`1025`	`unsigned char *buf = new unsigned char[size];`
`1026`	`1026`
`1027`	`1027`	`QgsWkbPtr wkbPtr( buf, size );`
`1028`		`- wkbPtr << ( char ) QgsApplication::endian() << QgsWkbTypes::LineString << mCaptureList.size();`
	`1028`	`+ wkbPtr << static_cast< char >( QgsApplication::endian() ) << QgsWkbTypes::LineString << mCaptureList.size();`
`1029`	`1029`
`1030`	`1030`	`for ( QList<QgsPointXY>::const_iterator it = mCaptureList.constBegin(); it != mCaptureList.constEnd(); ++it )`
`1031`	`1031`	`{`
`@@ -1043,11 +1043,11 @@ void QgsGpsInformationWidget::mBtnCloseFeature_clicked()`
`1043`	`1043`	`}`
`1044`	`1044`	`else if ( layerWKBType == QgsWkbTypes::Polygon )`
`1045`	`1045`	`{`
`1046`		`- int size = 1 + 3 * sizeof( int ) + 2 * ( mCaptureList.size() + 1 ) * sizeof( double );`
	`1046`	`+ int size = 1 + 3 * static_cast< int >( sizeof( int ) ) + 2 * ( mCaptureList.size() + 1 ) * static_cast< int >( sizeof( double ) );`
`1047`	`1047`	`unsigned char *buf = new unsigned char[size];`
`1048`	`1048`
`1049`	`1049`	`QgsWkbPtr wkbPtr( buf, size );`
`1050`		`- wkbPtr << ( char ) QgsApplication::endian() << QgsWkbTypes::Polygon << 1 << mCaptureList.size() + 1;`
	`1050`	`+ wkbPtr << static_cast< char >( QgsApplication::endian() ) << QgsWkbTypes::Polygon << 1 << mCaptureList.size() + 1;`
`1051`	`1051`
`1052`	`1052`	`QList<QgsPointXY>::iterator it;`
`1053`	`1053`	`for ( it = mCaptureList.begin(); it != mCaptureList.end(); ++it )`