Skip to content

Commit

Permalink
Fix single process build
Browse files Browse the repository at this point in the history 
A race condition triggered that sometimes the file
output/python/qgis/__init__.py was not created before a python uic
compiler started and therefore the required module could not be
imported.

This leads to errors like

[ 82%] Generating ui_dialogAbout.py
Traceback (most recent call last):
  File "../../../../../scripts/pyuic-wrapper.py", line 26, in <module>
    import qgis.PyQt.uic.pyuic
ImportError: No module named qgis.PyQt.uic.pyuic
python/plugins/GdalTools/tools/CMakeFiles/zzz-GdalTools-2-depend.dir/build.make:117:
recipe for target 'python/plugins/GdalTools/tools/ui_dialogAbout.py'
failed
make[2]: *** [python/plugins/GdalTools/tools/ui_dialogAbout.py] Error 1
CMakeFiles/Makefile2:5074: recipe for target
'python/plugins/GdalTools/tools/CMakeFiles/zzz-GdalTools-2-depend.dir/all'
failed
make[1]: ***
[python/plugins/GdalTools/tools/CMakeFiles/zzz-GdalTools-2-depend.dir/all]
Error 2
Makefile:160: recipe for target 'all' failed
make: *** [all] Error 2
  • Loading branch information
@m-kuhn
m-kuhn committed Jul 12, 2016
1 parent e59fda2 commit ae3db0a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions python/PyQt/CMakeLists.txt
View file
Expand Up @@ -21,6 +21,7 @@ SET(PYQT_COMPAT_FILES
)

ADD_CUSTOM_TARGET(pyqtcompat ALL)
ADD_DEPENDENCIES(pyqtcompat pyutils)

IF(ENABLE_QT5)
SET(PYQT_PREFIX PyQt5)
Expand Down

6 comments on commit ae3db0a

@nirvn
Copy link
Contributor

@nirvn nirvn commented on ae3db0a Jul 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh thanks.

@volter
Copy link
Contributor

@volter volter commented on ae3db0a Jul 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't seem to be enough. Fedora builds fail here, no matter how many jobs I run in parallel or not.

@m-kuhn
Copy link
Member Author

@m-kuhn m-kuhn commented on ae3db0a Jul 31, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you check if there is a file __init__.py created in build/output/python/qgis?

@volter
Copy link
Contributor

@volter volter commented on ae3db0a Jul 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, where? It's built in-source.

@m-kuhn
Copy link
Member Author

@m-kuhn m-kuhn commented on ae3db0a Jul 31, 2016 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tguyet
Copy link

@tguyet tguyet commented on ae3db0a Aug 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got the same problem. It was because of the "python-qgis" default package installed on my system and that was used instead of the compiled one.

Please sign in to comment.