don't crash when reply is destroyed while it's waiting for credentials

to be entered (backports 10a26e6)
qgis · Apr 5, 2016 · ae162d6 · ae162d6
1 parent b3f8a85
commit ae162d6
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/app/qgisapp.cpp b/src/app/qgisapp.cpp
@@ -10238,8 +10238,9 @@ void QgisApp::namSetup()
 #endif
 }
 
-void QgisApp::namAuthenticationRequired( QNetworkReply *reply, QAuthenticator *auth )
+void QgisApp::namAuthenticationRequired( QNetworkReply *inReply, QAuthenticator *auth )
 {
+  QPointer<QNetworkReply> reply( inReply );
   QString username = auth->user();
   QString password = auth->password();
 
@@ -10270,7 +10271,7 @@ void QgisApp::namAuthenticationRequired( QNetworkReply *reply, QAuthenticator *a
       if ( !ok )
         return;
 
-      if ( reply->isFinished() )
+      if ( reply.isNull() || reply->isFinished() )
         return;
 
       if ( auth->user() != username || ( password != auth->password() && !password.isNull() ) )