Fix incorrect result when calling changeAttributeValues on a non-edit…

…able layer
qgis · Nov 18, 2022 · adacd9a · adacd9a
1 parent b1e63a2
commit adacd9a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/core/vector/qgsvectorlayer.cpp b/src/core/vector/qgsvectorlayer.cpp
@@ -3185,9 +3185,12 @@ bool QgsVectorLayer::changeAttributeValues( QgsFeatureId fid, const QgsAttribute
     result = mJoinBuffer->changeAttributeValues( fid, newValuesJoin, oldValuesJoin );
   }
 
-  if ( ! newValuesNotJoin.isEmpty() && mEditBuffer && mDataProvider )
+  if ( ! newValuesNotJoin.isEmpty() )
   {
-    result &= mEditBuffer->changeAttributeValues( fid, newValuesNotJoin, oldValues );
+    if ( mEditBuffer && mDataProvider )
+      result &= mEditBuffer->changeAttributeValues( fid, newValuesNotJoin, oldValues );
+    else
+      result = false;
   }
 
   if ( result && !skipDefaultValues && !mDefaultValueOnUpdateFields.isEmpty() )