Skip to content

Commit

Permalink
Add missing doc
Browse files Browse the repository at this point in the history
  • Loading branch information
m-kuhn committed Oct 25, 2017
1 parent ca5cd88 commit ad7b2d0
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 8 deletions.
8 changes: 2 additions & 6 deletions python/core/qgsfeatureiterator.sip
Expand Up @@ -72,9 +72,7 @@ end of iterating: free the resources / lock

If you want to check if the iterator successfully completed, better use QgsFeatureIterator.isClosed().

.. note::

Added in QGIS 3.0
.. versionadded:: 3.0
:rtype: bool
%End

Expand Down Expand Up @@ -257,9 +255,7 @@ destructor deletes the iterator if it has no more references

.. seealso:: isClosed to check if the iterator successfully completed and returned all the features.

.. note::

Added in QGIS 3.0
.. versionadded:: 3.0
:rtype: bool
%End

Expand Down
7 changes: 7 additions & 0 deletions src/core/qgsconnectionpool.h
Expand Up @@ -85,6 +85,13 @@ class QgsConnectionPoolGroup
//! QgsConnectionPoolGroup cannot be copied
QgsConnectionPoolGroup &operator=( const QgsConnectionPoolGroup &other ) = delete;

/**
* Try to acquire a connection for a maximum of \a timeout milliseconds.
* If \a timeout is a negative value the calling thread will be blocked
* until a connection becomes available. This is the default behavior.
*
* \returns initialized connection or nullptr if unsuccessful
*/
T acquire( int timeout )
{
// we are going to acquire a resource - if no resource is available, we will block here
Expand Down
4 changes: 2 additions & 2 deletions src/core/qgsfeatureiterator.h
Expand Up @@ -90,7 +90,7 @@ class CORE_EXPORT QgsAbstractFeatureIterator
*
* If you want to check if the iterator successfully completed, better use QgsFeatureIterator::isClosed().
*
* @note Added in QGIS 3.0
* \since QGIS 3.0
*/
virtual bool isValid() const
{
Expand Down Expand Up @@ -311,7 +311,7 @@ class CORE_EXPORT QgsFeatureIterator
*
* \see isClosed to check if the iterator successfully completed and returned all the features.
*
* @note Added in QGIS 3.0
* \since QGIS 3.0
*/
virtual bool isValid() const;

Expand Down

0 comments on commit ad7b2d0

Please sign in to comment.