Merge pull request #9322 from m-kuhn/fix-double-delete

[geometry validation] Fix double delete and memory leak
qgis · Mar 2, 2019 · ac78a19 · ac78a19
2 parents 34684d4 + d1a7e45
commit ac78a19
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/app/qgsgeometryvalidationdock.cpp b/src/app/qgsgeometryvalidationdock.cpp
@@ -335,7 +335,7 @@ void QgsGeometryValidationDock::showHighlight( const QModelIndex &current )
 
     QPropertyAnimation *errorAnimation = new QPropertyAnimation( mErrorRubberband, "fillColor" );
     errorAnimation->setEasingCurve( QEasingCurve::OutQuad );
-    connect( errorAnimation, &QPropertyAnimation::finished, featureAnimation, &QPropertyAnimation::deleteLater );
+    connect( errorAnimation, &QPropertyAnimation::finished, errorAnimation, &QPropertyAnimation::deleteLater );
     connect( errorAnimation, &QPropertyAnimation::valueChanged, this, [this]
     {
       mErrorRubberband->update();