Restore some previous rendering behaviour

nyalldawson · nyalldawson · commit ac6bbd662df0 · 2021-11-07T17:16:59.000+11:00
diff --git a/src/core/raster/qgsrasterlayerrenderer.cpp b/src/core/raster/qgsrasterlayerrenderer.cpp
@@ -337,6 +337,9 @@ bool QgsRasterLayerRenderer::render()
     projector->setCrs( mRasterViewPort->mSrcCRS, mRasterViewPort->mDestCRS, mRasterViewPort->mTransformContext );
   }
 
+  // important -- disable SmoothPixmapTransform for raster layer renders. We want individual pixels to be clearly defined!
+  renderContext()->painter()->setRenderHint( QPainter::SmoothPixmapTransform, false );
+
   // Drawer to pipe?
   QgsRasterIterator iterator( mPipe->last() );
   QgsRasterDrawer drawer( &iterator, renderContext()->dpiTarget() );
diff --git a/src/core/textrenderer/qgstextrenderer.cpp b/src/core/textrenderer/qgstextrenderer.cpp
@@ -1233,8 +1233,10 @@ void QgsTextRenderer::drawShadow( QgsRenderContext &context, const QgsTextRender
                    -offsetDist * std::sin( angleRad + M_PI_2 ) );
 
   p->save();
-  p->setRenderHint( QPainter::SmoothPixmapTransform );
   context.setPainterFlagsUsingContext( p );
+  // this was historically ALWAYS set for text renderer. We may want to consider getting it to respect the
+  // corresponding flag in the render context instead...
+  p->setRenderHint( QPainter::SmoothPixmapTransform );
   if ( context.useAdvancedEffects() )
   {
     p->setCompositionMode( shadow.blendMode() );

Original file line number	Diff line number	Diff line change
`@@ -337,6 +337,9 @@ bool QgsRasterLayerRenderer::render()`
`337`	`337`	`projector->setCrs( mRasterViewPort->mSrcCRS, mRasterViewPort->mDestCRS, mRasterViewPort->mTransformContext );`
`338`	`338`	`}`
`339`	`339`
	`340`	`+ // important -- disable SmoothPixmapTransform for raster layer renders. We want individual pixels to be clearly defined!`
	`341`	`+ renderContext()->painter()->setRenderHint( QPainter::SmoothPixmapTransform, false );`
	`342`	`+`
`340`	`343`	`// Drawer to pipe?`
`341`	`344`	`QgsRasterIterator iterator( mPipe->last() );`
`342`	`345`	`QgsRasterDrawer drawer( &iterator, renderContext()->dpiTarget() );`