Skip to content

Commit

Permalink
Opacity should also be considered for external layers
Browse files Browse the repository at this point in the history
  • Loading branch information
mhugent authored and nyalldawson committed Apr 17, 2021
1 parent e8b7c9e commit ac5b7ea
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions src/server/services/wms/qgswmsparameters.cpp
Expand Up @@ -1539,6 +1539,9 @@ namespace QgsWms
QgsWmsParametersLayer param;
param.mNickname = layer;

if ( i < opacities.count() )
param.mOpacity = opacities[i];

if ( isExternalLayer( layer ) )
{
const QgsWmsParametersExternalLayer extParam = externalLayerParameter( layer );
Expand All @@ -1550,9 +1553,6 @@ namespace QgsWms
if ( i < styles.count() )
param.mStyle = styles[i];

if ( i < opacities.count() )
param.mOpacity = opacities[i];

if ( filters.contains( layer ) )
{
auto it = filters.find( layer );
Expand Down
10 changes: 5 additions & 5 deletions src/server/services/wms/qgswmsrenderer.cpp
Expand Up @@ -3208,6 +3208,11 @@ namespace QgsWms
continue;
}

if ( mContext.testFlag( QgsWmsRenderContext::UseOpacity ) )
{
setLayerOpacity( layer, param.mOpacity );
}

if ( mContext.isExternalLayer( param.mNickname ) )
{
continue;
Expand All @@ -3222,11 +3227,6 @@ namespace QgsWms
setLayerStyle( layer, mContext.style( *layer ) );
}

if ( mContext.testFlag( QgsWmsRenderContext::UseOpacity ) )
{
setLayerOpacity( layer, param.mOpacity );
}

if ( mContext.testFlag( QgsWmsRenderContext::UseFilter ) )
{
setLayerFilter( layer, param.mFilter );
Expand Down

0 comments on commit ac5b7ea

Please sign in to comment.