2D rendering of point clouds is NOT thread safe (argh\!)

qgis · Dec 16, 2022 · ac19285 · ac19285
1 parent cee0b53
commit ac19285
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/core/pointcloud/qgspointcloudlayer.cpp b/src/core/pointcloud/qgspointcloudlayer.cpp
@@ -122,7 +122,8 @@ QgsAbstractProfileGenerator *QgsPointCloudLayer::createProfileGenerator( const Q
 
 QgsPointCloudDataProvider *QgsPointCloudLayer::dataProvider()
 {
-  QGIS_PROTECT_QOBJECT_THREAD_ACCESS
+  // BAD! 2D rendering of point clouds is NOT thread safe
+  QGIS_PROTECT_QOBJECT_THREAD_ACCESS_NON_FATAL
 
   return mDataProvider.get();
 }

diff --git a/src/core/providers/ept/qgseptprovider.cpp b/src/core/providers/ept/qgseptprovider.cpp
@@ -99,7 +99,8 @@ QString QgsEptProvider::description() const
 
 QgsPointCloudIndex *QgsEptProvider::index() const
 {
-  QGIS_PROTECT_QOBJECT_THREAD_ACCESS
+  // BAD! 2D rendering of point clouds is NOT thread safe
+  QGIS_PROTECT_QOBJECT_THREAD_ACCESS_NON_FATAL
 
   return mIndex.get();
 }