[diagrams] Fix bars drawn outside of registered diagram extent for so…

…me orientations
qgis · Nov 23, 2019 · abb6438 · abb6438
1 parent a72f42b
commit abb6438
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 2 deletions.
diff --git a/src/core/diagram/qgshistogramdiagram.cpp b/src/core/diagram/qgshistogramdiagram.cpp
@@ -207,11 +207,11 @@ void QgsHistogramDiagram::renderDiagram( const QgsFeature &feature, QgsRenderCon
         break;
 
       case QgsDiagramSettings::Right:
-        p->drawRect( QRectF( baseX, baseY - scaledWidth * values.size() + currentOffset, length, scaledWidth * -1 ) );
+        p->drawRect( QRectF( baseX, baseY - scaledWidth * values.size() + currentOffset, length, scaledWidth ) );
         break;
 
       case QgsDiagramSettings::Left:
-        p->drawRect( QRectF( baseX + scaledMaxVal, baseY - scaledWidth * values.size() + currentOffset, 0 - length, scaledWidth * -1 ) );
+        p->drawRect( QRectF( baseX + scaledMaxVal, baseY - scaledWidth * values.size() + currentOffset, 0 - length, scaledWidth ) );
         break;
     }
 

diff --git a/...ata/control_images/diagrams/expected_histogram_left/expected_histogram_left.png b/...ata/control_images/diagrams/expected_histogram_left/expected_histogram_left.png
diff --git a/...ontrol_images/diagrams/expected_histogram_left/expected_histogram_left_mask.png b/...ontrol_images/diagrams/expected_histogram_left/expected_histogram_left_mask.png
diff --git a/...a/control_images/diagrams/expected_histogram_right/expected_histogram_right.png b/...a/control_images/diagrams/expected_histogram_right/expected_histogram_right.png
diff --git a/...trol_images/diagrams/expected_histogram_right/expected_histogram_right_mask.png b/...trol_images/diagrams/expected_histogram_right/expected_histogram_right_mask.png