Store cached layer render results based on whether each individual

job finished, not whether the whole map render finished This means that we will store cached results of layers which are faster to render and had already completed while a slower layer was still rendering and then the map render job was canceled. In this case we've already got a nice complete render of some layers ready for caching, so it's wasteful to discard these results and then redraw from scratch next time.
qgis · Jan 28, 2021 · ab94b20 · ab94b20
1 parent 2657da8
commit ab94b20
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/src/core/qgsmaprendererjob.cpp b/src/core/qgsmaprendererjob.cpp
@@ -682,7 +682,7 @@ void QgsMapRendererJob::cleanupJobs( LayerRenderJobs &jobs )
       delete job.context.painter();
       job.context.setPainter( nullptr );
 
-      if ( mCache && !job.cached && !job.context.renderingStopped() && job.layer )
+      if ( mCache && !job.cached && job.completed && job.layer )
       {
         QgsDebugMsgLevel( QStringLiteral( "caching image for %1" ).arg( job.layerId ), 2 );
         mCache->setCacheImage( job.layerId, *job.img, QList< QgsMapLayer * >() << job.layer );