Skip to content

Commit

Permalink
Start work on node edit tool
Browse files Browse the repository at this point in the history
  • Loading branch information
nyalldawson committed Nov 7, 2017
1 parent d92b067 commit ab7bb72
Show file tree
Hide file tree
Showing 11 changed files with 362 additions and 6 deletions.
1 change: 1 addition & 0 deletions python/gui/gui_auto.sip
Expand Up @@ -296,6 +296,7 @@
%Include layout/qgslayoutviewtool.sip
%Include layout/qgslayoutviewtooladditem.sip
%Include layout/qgslayoutviewtooladdnodeitem.sip
%Include layout/qgslayoutviewtooleditnodes.sip
%Include layout/qgslayoutviewtoolpan.sip
%Include layout/qgslayoutviewtoolselect.sip
%Include layout/qgslayoutviewtooltemporarykeypan.sip
Expand Down
49 changes: 49 additions & 0 deletions python/gui/layout/qgslayoutviewtooleditnodes.sip
@@ -0,0 +1,49 @@
/************************************************************************
* This file has been generated automatically from *
* *
* src/gui/layout/qgslayoutviewtooleditnodes.h *
* *
* Do not edit manually ! Edit header and run scripts/sipify.pl again *
************************************************************************/




class QgsLayoutViewToolEditNodes : QgsLayoutViewTool
{
%Docstring
Layout view tool for edit node based items in the layout.
.. versionadded:: 3.0
%End

%TypeHeaderCode
#include "qgslayoutviewtooleditnodes.h"
%End
public:

QgsLayoutViewToolEditNodes( QgsLayoutView *view /TransferThis/ );
%Docstring
Constructor for QgsLayoutViewToolEditNodes.
%End

virtual void activate();


virtual void layoutPressEvent( QgsLayoutViewMouseEvent *event );

virtual void layoutMoveEvent( QgsLayoutViewMouseEvent *event );

virtual void layoutReleaseEvent( QgsLayoutViewMouseEvent *event );

virtual void deactivate();


};

/************************************************************************
* This file has been generated automatically from *
* *
* src/gui/layout/qgslayoutviewtooleditnodes.h *
* *
* Do not edit manually ! Edit header and run scripts/sipify.pl again *
************************************************************************/
6 changes: 6 additions & 0 deletions src/app/layout/qgslayoutdesignerdialog.cpp
Expand Up @@ -28,6 +28,7 @@
#include "qgslayoutviewtoolpan.h"
#include "qgslayoutviewtoolzoom.h"
#include "qgslayoutviewtoolselect.h"
#include "qgslayoutviewtooleditnodes.h"
#include "qgslayoutitemwidget.h"
#include "qgsgui.h"
#include "qgslayoutitemguiregistry.h"
Expand Down Expand Up @@ -245,6 +246,11 @@ QgsLayoutDesignerDialog::QgsLayoutDesignerDialog( QWidget *parent, Qt::WindowFla
connect( mAddItemTool, &QgsLayoutViewToolAddItem::createdItem, this, [ = ] { mView->setTool( mSelectTool ); } );
connect( mAddNodeItemTool, &QgsLayoutViewToolAddNodeItem::createdItem, this, [ = ] { mView->setTool( mSelectTool ); } );

mNodesTool = new QgsLayoutViewToolEditNodes( mView );
mNodesTool->setAction( mActionEditNodesItem );
mToolsActionGroup->addAction( mActionEditNodesItem );
connect( mActionEditNodesItem, &QAction::triggered, mNodesTool, [ = ] { mView->setTool( mNodesTool ); } );

//Ctrl+= should also trigger zoom in
QShortcut *ctrlEquals = new QShortcut( QKeySequence( QStringLiteral( "Ctrl+=" ) ), this );
connect( ctrlEquals, &QShortcut::activated, mActionZoomIn, &QAction::trigger );
Expand Down
2 changes: 2 additions & 0 deletions src/app/layout/qgslayoutdesignerdialog.h
Expand Up @@ -28,6 +28,7 @@ class QgsLayoutViewToolAddNodeItem;
class QgsLayoutViewToolPan;
class QgsLayoutViewToolZoom;
class QgsLayoutViewToolSelect;
class QgsLayoutViewToolEditNodes;
class QgsLayoutRuler;
class QComboBox;
class QSlider;
Expand Down Expand Up @@ -275,6 +276,7 @@ class QgsLayoutDesignerDialog: public QMainWindow, private Ui::QgsLayoutDesigner
QgsLayoutViewToolPan *mPanTool = nullptr;
QgsLayoutViewToolZoom *mZoomTool = nullptr;
QgsLayoutViewToolSelect *mSelectTool = nullptr;
QgsLayoutViewToolEditNodes *mNodesTool = nullptr;

QMap< QString, QToolButton * > mItemGroupToolButtons;
QMap< QString, QMenu * > mItemGroupSubmenus;
Expand Down
2 changes: 1 addition & 1 deletion src/core/layout/qgslayoutitem.cpp
Expand Up @@ -418,7 +418,7 @@ void QgsLayoutItem::attemptMove( const QgsLayoutPoint &p, bool useReferencePoint

void QgsLayoutItem::attemptSetSceneRect( const QRectF &rect, bool includesFrame )
{
QPointF newPos = mapToScene( rect.topLeft() );
QPointF newPos = rect.topLeft();

blockSignals( true );
// translate new size to current item units
Expand Down
11 changes: 6 additions & 5 deletions src/core/layout/qgslayoutitemnodeitem.cpp
Expand Up @@ -150,7 +150,9 @@ bool QgsLayoutNodesItem::addNode( QPointF pt,

void QgsLayoutNodesItem::drawNodes( QgsRenderContext &context, const QStyleOptionGraphicsItem *itemStyle ) const
{
double rectSize = 3.0 / itemStyle->matrix.m11();
context.painter()->setRenderHint( QPainter::Antialiasing, false );

double rectSize = 9.0 / itemStyle->matrix.m11();

QgsStringMap properties;
properties.insert( QStringLiteral( "name" ), QStringLiteral( "cross" ) );
Expand All @@ -163,7 +165,7 @@ void QgsLayoutNodesItem::drawNodes( QgsRenderContext &context, const QStyleOptio

symbol->startRender( context );
for ( QPointF pt : mPolygon )
symbol->renderPoint( pt, nullptr, context );
symbol->renderPoint( pt * itemStyle->matrix.m11(), nullptr, context );
symbol->stopRender( context );

if ( mSelectedNode >= 0 && mSelectedNode < mPolygon.size() )
Expand All @@ -172,7 +174,7 @@ void QgsLayoutNodesItem::drawNodes( QgsRenderContext &context, const QStyleOptio

void QgsLayoutNodesItem::drawSelectedNode( QgsRenderContext &context, const QStyleOptionGraphicsItem *itemStyle ) const
{
double rectSize = 3.0 / itemStyle->matrix.m11();
double rectSize = 9.0 / itemStyle->matrix.m11();

QgsStringMap properties;
properties.insert( QStringLiteral( "name" ), QStringLiteral( "square" ) );
Expand All @@ -185,7 +187,7 @@ void QgsLayoutNodesItem::drawSelectedNode( QgsRenderContext &context, const QSty
symbol->setSize( rectSize );

symbol->startRender( context );
symbol->renderPoint( mPolygon.at( mSelectedNode ), nullptr, context );
symbol->renderPoint( mPolygon.at( mSelectedNode ) * itemStyle->matrix.m11(), nullptr, context );
symbol->stopRender( context );
}

Expand Down Expand Up @@ -317,7 +319,6 @@ void QgsLayoutNodesItem::updateSceneRect()
// update
prepareGeometryChange();
update();
emit sizePositionChanged();
}


Expand Down
2 changes: 2 additions & 0 deletions src/gui/CMakeLists.txt
Expand Up @@ -171,6 +171,7 @@ SET(QGIS_GUI_SRCS
layout/qgslayoutviewtool.cpp
layout/qgslayoutviewtooladditem.cpp
layout/qgslayoutviewtooladdnodeitem.cpp
layout/qgslayoutviewtooleditnodes.cpp
layout/qgslayoutviewtoolpan.cpp
layout/qgslayoutviewtoolselect.cpp
layout/qgslayoutviewtooltemporarykeypan.cpp
Expand Down Expand Up @@ -675,6 +676,7 @@ SET(QGIS_GUI_MOC_HDRS
layout/qgslayoutviewtool.h
layout/qgslayoutviewtooladditem.h
layout/qgslayoutviewtooladdnodeitem.h
layout/qgslayoutviewtooleditnodes.h
layout/qgslayoutviewtoolpan.h
layout/qgslayoutviewtoolselect.h
layout/qgslayoutviewtooltemporarykeypan.h
Expand Down
168 changes: 168 additions & 0 deletions src/gui/layout/qgslayoutviewtooleditnodes.cpp
@@ -0,0 +1,168 @@
/***************************************************************************
qgslayoutviewtooleditnodes.cpp
---------------------------
Date : July 2017
Copyright : (C) 2017 Nyall Dawson
Email : nyall dot dawson at gmail dot com
***************************************************************************
* *
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
* *
***************************************************************************/

#include "qgslayoutviewtooleditnodes.h"
#include "qgslayoutviewmouseevent.h"
#include "qgslayoutview.h"
#include "qgslayout.h"
#include "qgslayoutitemnodeitem.h"

QgsLayoutViewToolEditNodes::QgsLayoutViewToolEditNodes( QgsLayoutView *view )
: QgsLayoutViewTool( view, tr( "Select" ) )
{
setCursor( Qt::CrossCursor );
setFlags( QgsLayoutViewTool::FlagSnaps );
}

void QgsLayoutViewToolEditNodes::activate()
{
displayNodes( true );
QgsLayoutViewTool::activate();
}

void QgsLayoutViewToolEditNodes::layoutPressEvent( QgsLayoutViewMouseEvent *event )
{
if ( event->button() != Qt::LeftButton )
{
event->ignore();
return;
}

const QList<QGraphicsItem *> itemsAtCursorPos = view()->items( event->pos().x(), event->pos().y(),
mMoveContentSearchRadius,
mMoveContentSearchRadius );
if ( itemsAtCursorPos.isEmpty() )
return;

mNodesItemIndex = -1;
mNodesItem = nullptr;
isMoving = false;

for ( QGraphicsItem *graphicsItem : itemsAtCursorPos )
{
QgsLayoutNodesItem *item = dynamic_cast<QgsLayoutNodesItem *>( graphicsItem );

if ( item && !item->isLocked() )
{
int index = item->nodeAtPosition( event->layoutPoint() );
if ( index != -1 )
{
mNodesItemIndex = index;
mNodesItem = item;
mMoveContentStartPos = event->layoutPoint();
}
}

if ( mNodesItemIndex != -1 )
{
layout()->undoStack()->beginCommand( mNodesItem, tr( "Move Item Node" ) );
setSelectedNode( mNodesItem, mNodesItemIndex );
isMoving = true;
break;
}
}
}

void QgsLayoutViewToolEditNodes::layoutMoveEvent( QgsLayoutViewMouseEvent *event )
{
if ( !isMoving )
{
event->ignore();
return;
}

if ( mNodesItemIndex != -1 && event->layoutPoint() != mMoveContentStartPos )
{
mNodesItem->moveNode( mNodesItemIndex, event->snappedPoint() );
}
}

void QgsLayoutViewToolEditNodes::layoutReleaseEvent( QgsLayoutViewMouseEvent *event )
{
if ( event->button() != Qt::LeftButton || !isMoving )
{
event->ignore();
return;
}

isMoving = false;
if ( mNodesItemIndex != -1 )
{
if ( event->layoutPoint() != mMoveContentStartPos )
{
layout()->undoStack()->endCommand();
}
else
{
layout()->undoStack()->cancelCommand();
}
}
}

void QgsLayoutViewToolEditNodes::deactivate()
{
displayNodes( false );
deselectNodes();
QgsLayoutViewTool::deactivate();
}

void QgsLayoutViewToolEditNodes::displayNodes( bool display )
{
QList<QgsLayoutNodesItem *> nodesShapes;
layout()->layoutItems( nodesShapes );

for ( QgsLayoutNodesItem *item : qgis::as_const( nodesShapes ) )
{
item->setDisplayNodes( display );
}

layout()->update();
}

void QgsLayoutViewToolEditNodes::deselectNodes()
{
QList<QgsLayoutNodesItem *> nodesShapes;
layout()->layoutItems( nodesShapes );

for ( QgsLayoutNodesItem *item : qgis::as_const( nodesShapes ) )
{
item->deselectNode();
}

layout()->update();
}

void QgsLayoutViewToolEditNodes::setSelectedNode( QgsLayoutNodesItem *shape, int index )
{
QList<QgsLayoutNodesItem *> nodesShapes;
layout()->layoutItems( nodesShapes );

for ( QgsLayoutNodesItem *item : qgis::as_const( nodesShapes ) )
{
if ( item == shape )
{
item->setSelectedNode( index );
layout()->setSelectedItem( item );
item->update();
}
else
{
item->deselectNode();
item->update();
}
}

}

0 comments on commit ab7bb72

Please sign in to comment.