Copy! References in lambdas are dangerous

elpaso · elpaso · commit ab7b45704cd2 · 2018-11-05T10:24:35.000+01:00
Note to self: repeat 3 times:

Copy! References in lambdas are dangerous
Copy! References in lambdas are dangerous
Copy! References in lambdas are dangerous
diff --git a/src/app/qgsapplayertreeviewmenuprovider.cpp b/src/app/qgsapplayertreeviewmenuprovider.cpp
@@ -204,7 +204,7 @@ QMenu *QgsAppLayerTreeViewMenuProvider::createContextMenu()
       {
 
         QAction *a = new QAction( tr( "Change data source" ), menu );
-        connect( a, &QAction::triggered, [ & ]
+        connect( a, &QAction::triggered, [ = ]
         {
           QgisApp::instance()->changeDataSource( layer );
         } );

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,7 @@ QMenu *QgsAppLayerTreeViewMenuProvider::createContextMenu()`
`204`	`204`	`{`
`205`	`205`
`206`	`206`	`QAction *a = new QAction( tr( "Change data source" ), menu );`
`207`		`- connect( a, &QAction::triggered, [ & ]`
	`207`	`+ connect( a, &QAction::triggered, [ = ]`
`208`	`208`	`{`
`209`	`209`	`QgisApp::instance()->changeDataSource( layer );`
`210`	`210`	`} );`