Fix leak in QgsCoordinateReferenceSystem

nyalldawson · nyalldawson · commit aad7c5eaafb5 · 2017-02-08T07:07:22.000+10:00
diff --git a/src/core/qgscoordinatereferencesystem_p.h b/src/core/qgscoordinatereferencesystem_p.h
@@ -65,7 +65,7 @@ class QgsCoordinateReferenceSystemPrivate : public QSharedData
         , mSRID( other.mSRID )
         , mAuthId( other.mAuthId )
         , mIsValid( other.mIsValid )
-        , mCRS( OSRNewSpatialReference( nullptr ) )
+        , mCRS( nullptr )
         , mValidationHint( other.mValidationHint )
         , mWkt( other.mWkt )
         , mProj4( other.mProj4 )
@@ -76,6 +76,10 @@ class QgsCoordinateReferenceSystemPrivate : public QSharedData
       {
         mCRS = OSRClone( other.mCRS );
       }
+      else
+      {
+        mCRS = OSRNewSpatialReference( nullptr );
+      }
     }
 
     ~QgsCoordinateReferenceSystemPrivate()

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ class QgsCoordinateReferenceSystemPrivate : public QSharedData`
`65`	`65`	`, mSRID( other.mSRID )`
`66`	`66`	`, mAuthId( other.mAuthId )`
`67`	`67`	`, mIsValid( other.mIsValid )`
`68`		`- , mCRS( OSRNewSpatialReference( nullptr ) )`
	`68`	`+ , mCRS( nullptr )`
`69`	`69`	`, mValidationHint( other.mValidationHint )`
`70`	`70`	`, mWkt( other.mWkt )`
`71`	`71`	`, mProj4( other.mProj4 )`
`@@ -76,6 +76,10 @@ class QgsCoordinateReferenceSystemPrivate : public QSharedData`
`76`	`76`	`{`
`77`	`77`	`mCRS = OSRClone( other.mCRS );`
`78`	`78`	`}`
	`79`	`+ else`
	`80`	`+ {`
	`81`	`+ mCRS = OSRNewSpatialReference( nullptr );`
	`82`	`+ }`
`79`	`83`	`}`
`80`	`84`
`81`	`85`	`~QgsCoordinateReferenceSystemPrivate()`