fix save connection dialog

3nids · web-flow · commit aa78d751fd88 · 2023-04-04T07:37:11.000+02:00
fixes #52519
diff --git a/src/gui/qgsmanageconnectionsdialog.cpp b/src/gui/qgsmanageconnectionsdialog.cpp
@@ -237,8 +237,7 @@ bool QgsManageConnectionsDialog::populateConnections()
   // Export mode. Populate connections list from settings
   if ( mDialogMode == Export )
   {
-    QStringList connections;
-    QgsSettings settings;
+    const QStringList connections;
     switch ( mConnectionType )
     {
       case WMS:
@@ -273,19 +272,12 @@ bool QgsManageConnectionsDialog::populateConnections()
         connections = QgsVectorTileProviderConnection::sTreeConnectionVectorTile->items();
         break;
     }
-    if ( !settings.group().isEmpty() )
-    {
-      QStringList keys = settings.childGroups();
-      QStringList::Iterator it = keys.begin();
-      while ( it != keys.end() )
+      for ( const QString& connection : connections)
       {
         QListWidgetItem *item = new QListWidgetItem();
-        item->setText( *it );
+        item->setText( connection );
         listConnections->addItem( item );
-        ++it;
       }
-      settings.endGroup();
-    }
   }
   // Import mode. Populate connections list from file
   else

Original file line number	Diff line number	Diff line change
`@@ -237,8 +237,7 @@ bool QgsManageConnectionsDialog::populateConnections()`
`237`	`237`	`// Export mode. Populate connections list from settings`
`238`	`238`	`if ( mDialogMode == Export )`
`239`	`239`	`{`
`240`		`- QStringList connections;`
`241`		`- QgsSettings settings;`
	`240`	`+ const QStringList connections;`
`242`	`241`	`switch ( mConnectionType )`
`243`	`242`	`{`
`244`	`243`	`case WMS:`
`@@ -273,19 +272,12 @@ bool QgsManageConnectionsDialog::populateConnections()`
`273`	`272`	`connections = QgsVectorTileProviderConnection::sTreeConnectionVectorTile->items();`
`274`	`273`	`break;`
`275`	`274`	`}`
`276`		`- if ( !settings.group().isEmpty() )`
`277`		`- {`
`278`		`- QStringList keys = settings.childGroups();`
`279`		`- QStringList::Iterator it = keys.begin();`
`280`		`- while ( it != keys.end() )`
	`275`	`+ for ( const QString& connection : connections)`
`281`	`276`	`{`
`282`	`277`	`QListWidgetItem *item = new QListWidgetItem();`
`283`		`- item->setText( *it );`
	`278`	`+ item->setText( connection );`
`284`	`279`	`listConnections->addItem( item );`
`285`		`- ++it;`
`286`	`280`	`}`
`287`		`- settings.endGroup();`
`288`		`- }`
`289`	`281`	`}`
`290`	`282`	`// Import mode. Populate connections list from file`
`291`	`283`	`else`