QList::removeAt crashes in qt6 if index is -1, so use QList::removeAl…

…l instead of QList::removeAt( QList::indexOf(...
qgis · Jul 28, 2021 · a9f08b0 · a9f08b0
1 parent 5b4d6c3
commit a9f08b0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/core/classification/qgsclassificationmethod.cpp b/src/core/classification/qgsclassificationmethod.cpp
@@ -325,9 +325,9 @@ void QgsClassificationMethod::makeBreaksSymmetric( QList<double> &breaks, double
     }
   }
   // remove symmetry point
-  if ( astride ) // && breaks.indexOf( symmetryPoint ) != -1) // if symmetryPoint is found
+  if ( astride )
   {
-    breaks.removeAt( breaks.indexOf( symmetryPoint ) );
+    breaks.removeAll( symmetryPoint );
   }
 }
 

diff --git a/src/core/qgsrenderchecker.cpp b/src/core/qgsrenderchecker.cpp
@@ -106,7 +106,7 @@ bool QgsRenderChecker::isKnownAnomaly( const QString &diffImageFile )
                                   QDir::Files | QDir::NoSymLinks );
   //remove the control file from the list as the anomalies are
   //all files except the control file
-  myList.removeAt( myList.indexOf( QFileInfo( mExpectedImageFile ).fileName() ) );
+  myList.removeAll( QFileInfo( mExpectedImageFile ).fileName() );
 
   QString myImageHash = imageToHash( diffImageFile );