Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Use translated strings while logging profiles
  • Loading branch information
nyalldawson committed May 18, 2020
1 parent a913a6a commit a990adf
Showing 1 changed file with 30 additions and 31 deletions.
61 changes: 30 additions & 31 deletions src/app/qgisapp.cpp
Expand Up @@ -832,7 +832,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
sInstance = this;
QgsRuntimeProfiler *profiler = QgsApplication::profiler();

startProfile( QStringLiteral( "User profile manager" ) );
startProfile( tr( "User profile manager" ) );
mUserProfileManager = new QgsUserProfileManager( QString(), this );
mUserProfileManager->setRootLocation( rootProfileLocation );
mUserProfileManager->setActiveUserProfile( activeProfile );
Expand All @@ -841,14 +841,13 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
endProfile();

// start the network logger early, we want all requests logged!
startProfile( QStringLiteral( "Network logger" ) );
startProfile( tr( "Network logger" ) );
mNetworkLogger = new QgsNetworkLogger( QgsNetworkAccessManager::instance(), this );
endProfile();

// load GUI: actions, menus, toolbars
profiler->beginGroup( QStringLiteral( "qgisapp" ) );
profiler->beginGroup( QStringLiteral( "startup" ) );
startProfile( QStringLiteral( "Setting up UI" ) );
profiler->start( tr( "Application startup" ) );
startProfile( tr( "Setting up UI" ) );
setupUi( this );
// because mActionToggleMapOnly can hide the menu (thereby disabling menu actions),
// we attach the following actions to the MainWindow too (to be able to come back)
Expand All @@ -861,7 +860,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh

//////////

startProfile( QStringLiteral( "Checking database" ) );
startProfile( tr( "Checking database" ) );
mSplash->showMessage( tr( "Checking database" ), Qt::AlignHCenter | Qt::AlignBottom );
qApp->processEvents();
// Do this early on before anyone else opens it and prevents us copying it
Expand All @@ -873,7 +872,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
endProfile();

// Create the themes folder for the user
startProfile( QStringLiteral( "Creating theme folder" ) );
startProfile( tr( "Creating theme folder" ) );
QgsApplication::createThemeFolder();
endProfile();

Expand All @@ -893,7 +892,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
QgsSettings settings;


startProfile( QStringLiteral( "Building style sheet" ) );
startProfile( tr( "Building style sheet" ) );
// set up stylesheet builder and apply saved or default style options
mStyleSheetBuilder = new QgisAppStyleSheet( this );
connect( mStyleSheetBuilder, &QgisAppStyleSheet::appStyleSheetChanged,
Expand All @@ -906,7 +905,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
centralLayout->setContentsMargins( 0, 0, 0, 0 );

// "theMapCanvas" used to find this canonical instance later
startProfile( QStringLiteral( "Creating map canvas" ) );
startProfile( tr( "Creating map canvas" ) );
mMapCanvas = new QgsMapCanvas( centralWidget );
mMapCanvas->setObjectName( QStringLiteral( "theMapCanvas" ) );

Expand All @@ -933,13 +932,13 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
mProjOpen = settings.value( QStringLiteral( "qgis/projOpenAtLaunch" ), 0 ).toInt();

// a bar to warn the user with non-blocking messages
startProfile( QStringLiteral( "Message bar" ) );
startProfile( tr( "Message bar" ) );
mInfoBar = new QgsMessageBar( centralWidget );
mInfoBar->setSizePolicy( QSizePolicy::Minimum, QSizePolicy::Fixed );
centralLayout->addWidget( mInfoBar, 0, 0, 1, 1 );
endProfile();

startProfile( QStringLiteral( "Welcome page" ) );
startProfile( tr( "Welcome page" ) );
mWelcomePage = new QgsWelcomePage( skipVersionCheck );
connect( mWelcomePage, &QgsWelcomePage::projectRemoved, this, [ this ]( int row )
{
Expand Down Expand Up @@ -972,7 +971,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh

mCentralContainer->setCurrentIndex( mProjOpen ? 0 : 1 );

startProfile( QStringLiteral( "User input dock" ) );
startProfile( tr( "User input dock" ) );
// User Input Dock Widget
mUserInputDockWidget = new QgsUserInputWidget( mMapCanvas );
mUserInputDockWidget->setObjectName( QStringLiteral( "UserInputDockWidget" ) );
Expand All @@ -985,13 +984,13 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
//set the focus to the map canvas
mMapCanvas->setFocus();

startProfile( QStringLiteral( "Layer tree" ) );
startProfile( tr( "Layer tree" ) );
mLayerTreeView = new QgsLayerTreeView( this );
mLayerTreeView->setObjectName( QStringLiteral( "theLayerTreeView" ) ); // "theLayerTreeView" used to find this canonical instance later
endProfile();

// create undo widget
startProfile( QStringLiteral( "Undo dock" ) );
startProfile( tr( "Undo dock" ) );
mUndoDock = new QgsDockWidget( tr( "Undo/Redo" ), this );
QShortcut *showUndoDock = new QShortcut( QKeySequence( tr( "Ctrl+5" ) ), this );
connect( showUndoDock, &QShortcut::activated, mUndoDock, &QgsDockWidget::toggleUserVisible );
Expand All @@ -1005,7 +1004,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
endProfile();

// Advanced Digitizing dock
startProfile( QStringLiteral( "Advanced digitize panel" ) );
startProfile( tr( "Advanced digitize panel" ) );
mAdvancedDigitizingDockWidget = new QgsAdvancedDigitizingDockWidget( mMapCanvas, this );
mAdvancedDigitizingDockWidget->setWindowTitle( tr( "Advanced Digitizing" ) );
mAdvancedDigitizingDockWidget->setObjectName( QStringLiteral( "AdvancedDigitizingTools" ) );
Expand All @@ -1018,7 +1017,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
endProfile();

// Statistical Summary dock
startProfile( QStringLiteral( "Stats dock" ) );
startProfile( tr( "Statistics dock" ) );
mStatisticalSummaryDockWidget = new QgsStatisticalSummaryDockWidget( this );
mStatisticalSummaryDockWidget->setObjectName( QStringLiteral( "StatisticalSummaryDockWidget" ) );

Expand All @@ -1030,7 +1029,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
endProfile();

// Bookmarks dock
startProfile( QStringLiteral( "Bookmarks widget" ) );
startProfile( tr( "Bookmarks widget" ) );
mBookMarksDockWidget = new QgsBookmarks( this );
mBookMarksDockWidget->setObjectName( QStringLiteral( "BookmarksDockWidget" ) );

Expand All @@ -1044,7 +1043,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh

endProfile();

startProfile( QStringLiteral( "Snapping utils" ) );
startProfile( tr( "Snapping utilities" ) );
mSnappingUtils = new QgsMapCanvasSnappingUtils( mMapCanvas, this );
mMapCanvas->setSnappingUtils( mSnappingUtils );
connect( QgsProject::instance(), &QgsProject::snappingConfigChanged, mSnappingUtils, &QgsSnappingUtils::setConfig );
Expand All @@ -1062,7 +1061,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh

applyDefaultSettingsToCanvas( mMapCanvas );

functionProfile( &QgisApp::initLayerTreeView, this, QStringLiteral( "Init Layer tree view" ) );
functionProfile( &QgisApp::initLayerTreeView, this, QStringLiteral( "Initialize layer tree view" ) );
functionProfile( &QgisApp::createOverview, this, QStringLiteral( "Create overview" ) );
functionProfile( &QgisApp::createMapTips, this, QStringLiteral( "Create map tips" ) );
functionProfile( &QgisApp::createDecorations, this, QStringLiteral( "Create decorations" ) );
Expand All @@ -1073,7 +1072,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
functionProfile( &QgisApp::initNativeProcessing, this, QStringLiteral( "Initialize native processing" ) );
functionProfile( &QgisApp::initLayouts, this, QStringLiteral( "Initialize layouts support" ) );

startProfile( QStringLiteral( "Geometry validation" ) );
startProfile( tr( "Geometry validation" ) );

mGeometryValidationService = qgis::make_unique<QgsGeometryValidationService>( QgsProject::instance() );
mGeometryValidationService->setMessageBar( mInfoBar );
Expand Down Expand Up @@ -1109,14 +1108,14 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
}

// initialize the plugin manager
startProfile( QStringLiteral( "Plugin manager" ) );
startProfile( tr( "Plugin manager" ) );
mPluginManager = new QgsPluginManager( this, restorePlugins );
endProfile();

addDockWidget( Qt::LeftDockWidgetArea, mUndoDock );
mUndoDock->hide();

startProfile( QStringLiteral( "Layer Style dock" ) );
startProfile( tr( "Layer style dock" ) );
mMapStylingDock = new QgsDockWidget( this );
mMapStylingDock->setWindowTitle( tr( "Layer Styling" ) );
mMapStylingDock->setObjectName( QStringLiteral( "LayerStyling" ) );
Expand All @@ -1134,7 +1133,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
mMapStylingDock->hide();
endProfile();

startProfile( QStringLiteral( "Dev Tools dock" ) );
startProfile( tr( "Developer tools dock" ) );
mDevToolsDock = new QgsDockWidget( this );
mDevToolsDock->setWindowTitle( tr( "Debugging/Development Tools" ) );
mDevToolsDock->setObjectName( QStringLiteral( "DevTools" ) );
Expand All @@ -1151,7 +1150,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
mDevToolsDock->hide();
endProfile();

startProfile( QStringLiteral( "Snapping dialog" ) );
startProfile( tr( "Snapping dialog" ) );
mSnappingDialog = new QgsSnappingWidget( QgsProject::instance(), mMapCanvas, this );
connect( mSnappingDialog, &QgsSnappingWidget::snappingConfigChanged, QgsProject::instance(), [ = ] { QgsProject::instance()->setSnappingConfig( mSnappingDialog->config() ); } );
QString mainSnappingWidgetMode = QgsSettings().value( QStringLiteral( "/qgis/mainSnappingWidgetMode" ), "dialog" ).toString();
Expand Down Expand Up @@ -1381,7 +1380,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
#ifdef WITH_BINDINGS
if ( mPythonUtils && mPythonUtils->isEnabled() )
{
startProfile( QStringLiteral( "initPluginInstaller" ) );
startProfile( tr( "Plugin installer" ) );
// initialize the plugin installer to start fetching repositories in background
QgsPythonRunner::run( QStringLiteral( "import pyplugin_installer" ) );
QgsPythonRunner::run( QStringLiteral( "pyplugin_installer.initPluginInstaller()" ) );
Expand All @@ -1399,7 +1398,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
}

// Update recent project list (as possible custom project storages are now registered by plugins)
startProfile( QStringLiteral( "Update recent project paths" ) );
startProfile( tr( "Update recent project paths" ) );
updateRecentProjectPaths();
mWelcomePage->setRecentProjects( mRecentProjects );
endProfile();
Expand Down Expand Up @@ -1452,17 +1451,17 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
//
mSplash->showMessage( tr( "Restoring window state" ), Qt::AlignHCenter | Qt::AlignBottom );
qApp->processEvents();
startProfile( QStringLiteral( "Restore window state" ) );
startProfile( tr( "Restore window state" ) );
restoreWindowState();
endProfile();

// do main window customization - after window state has been restored, before the window is shown
startProfile( QStringLiteral( "Update customization on main window" ) );
startProfile( tr( "Update customization on main window" ) );
QgsCustomization::instance()->updateMainWindow( mToolbarMenu );
endProfile();

mSplash->showMessage( tr( "Populate saved styles" ), Qt::AlignHCenter | Qt::AlignBottom );
startProfile( QStringLiteral( "Populate saved styles" ) );
startProfile( tr( "Populate saved styles" ) );
QgsStyle::defaultStyle();
endProfile();

Expand All @@ -1486,7 +1485,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh

mFullScreenMode = false;
mPrevScreenModeMaximized = false;
startProfile( QStringLiteral( "Show main window" ) );
startProfile( tr( "Show main window" ) );
show();
qApp->processEvents();
endProfile();
Expand Down Expand Up @@ -1617,7 +1616,7 @@ QgisApp::QgisApp( QSplashScreen *splash, bool restorePlugins, bool skipVersionCh
// notify user if authentication system is disabled
( void )QgsAuthGuiUtils::isDisabled( messageBar() );

startProfile( QStringLiteral( "New project" ) );
startProfile( tr( "New project" ) );
fileNewBlank(); // prepare empty project, also skips any default templates from loading
updateCrsStatusBar();
endProfile();
Expand Down

0 comments on commit a990adf

Please sign in to comment.