Better logic for sql layer tests

qgis · Jul 9, 2021 · a94e089 · a94e089
1 parent 3cac2e7
commit a94e089
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/tests/src/python/test_qgsproviderconnection_base.py b/tests/src/python/test_qgsproviderconnection_base.py
@@ -529,22 +529,19 @@ def testCreateSqlVectorLayer(self):
             print(f"FIXME: {self.providerKey} data provider does not support query layers!")
             return
 
-        try:
-            schema = getattr(self, 'sqlVectorLayerSchema')
-        except:  # noqa: E722
+        schema = getattr(self, 'sqlVectorLayerSchema', None)
+        if schema is None:
             print(f"FIXME: {self.providerKey} data provider test case does not define self.sqlVectorLayerSchema for query layers test!")
             return
 
-        try:
-            table = getattr(self, 'sqlVectorLayerTable')
-        except:  # noqa: E722
+        table = getattr(self, 'sqlVectorLayerTable', None)
+        if table is None:
             print(f"FIXME: {self.providerKey} data provider test case does not define self.sqlVectorLayerTable for query layers test!")
             return
 
         sql_layer_capabilities = conn.sqlLayerDefinitionCapabilities()
 
         # Try a simple select first
-
         table_info = conn.table(schema, table)
 
         options = QgsAbstractDatabaseProviderConnection.SqlVectorLayerOptions()