Avoid Coverity unchecked return value warnings

nyalldawson · nyalldawson · commit a9145f16cc99 · 2017-11-11T15:48:19.000+10:00
diff --git a/src/app/qgsattributetabledialog.cpp b/src/app/qgsattributetabledialog.cpp
@@ -510,7 +510,7 @@ void QgsAttributeTableDialog::runFieldCalculation( QgsVectorLayer *layer, const
     context.lastScope()->addVariable( QgsExpressionContextScope::StaticVariable( QStringLiteral( "row_number" ), rownum, true ) );
 
     QVariant value = exp.evaluate( &context );
-    fld.convertCompatible( value );
+    ( void )fld.convertCompatible( value );
     // Bail if we have a update error
     if ( exp.hasEvalError() )
     {
diff --git a/src/app/qgsfieldcalculator.cpp b/src/app/qgsfieldcalculator.cpp
@@ -299,7 +299,7 @@ void QgsFieldCalculator::accept()
       }
       else
       {
-        field.convertCompatible( value );
+        ( void )field.convertCompatible( value );
         mVectorLayer->changeAttributeValue( feature.id(), mAttributeId, value, newField ? emptyAttribute : feature.attributes().value( mAttributeId ) );
       }
 
diff --git a/src/core/qgsvectorlayerfeatureiterator.cpp b/src/core/qgsvectorlayerfeatureiterator.cpp
@@ -875,7 +875,7 @@ void QgsVectorLayerFeatureIterator::addExpressionAttribute( QgsFeature &f, int a
   {
     mExpressionContext->setFeature( f );
     QVariant val = exp->evaluate( mExpressionContext.get() );
-    mSource->mFields.at( attrIndex ).convertCompatible( val );
+    ( void )mSource->mFields.at( attrIndex ).convertCompatible( val );
     f.setAttribute( attrIndex, val );
   }
   else
diff --git a/src/gui/editorwidgets/qgsrangewidgetwrapper.cpp b/src/gui/editorwidgets/qgsrangewidgetwrapper.cpp
@@ -141,9 +141,9 @@ void QgsRangeWidgetWrapper::initWidget( QWidget *editor )
   }
   else
   {
-    field().convertCompatible( min );
-    field().convertCompatible( max );
-    field().convertCompatible( step );
+    ( void )field().convertCompatible( min );
+    ( void )field().convertCompatible( max );
+    ( void )field().convertCompatible( step );
     if ( mQgsDial ) setupIntEditor( min, max, step, mQgsDial, this );
     else if ( mQgsSlider ) setupIntEditor( min, max, step, mQgsSlider, this );
     else if ( mDial ) setupIntEditor( min, max, step, mDial, this );
diff --git a/tests/src/core/testqgslayoutmodel.cpp b/tests/src/core/testqgslayoutmodel.cpp
@@ -789,7 +789,7 @@ void TestQgsLayoutModel::proxyCrash()
   layout->addLayoutItem( item3 );
 
   // reorder items - expect no crash!
-  layout->itemsModel()->reorderItemUp( item1 );
+  ( void )layout->itemsModel()->reorderItemUp( item1 );
 }
 
 QGSTEST_MAIN( TestQgsLayoutModel )

Original file line number	Diff line number	Diff line change
`@@ -510,7 +510,7 @@ void QgsAttributeTableDialog::runFieldCalculation( QgsVectorLayer *layer, const`
`510`	`510`	`context.lastScope()->addVariable( QgsExpressionContextScope::StaticVariable( QStringLiteral( "row_number" ), rownum, true ) );`
`511`	`511`
`512`	`512`	`QVariant value = exp.evaluate( &context );`
`513`		`- fld.convertCompatible( value );`
	`513`	`+ ( void )fld.convertCompatible( value );`
`514`	`514`	`// Bail if we have a update error`
`515`	`515`	`if ( exp.hasEvalError() )`
`516`	`516`	`{`
Original file line number	Diff line number	Diff line change
`@@ -299,7 +299,7 @@ void QgsFieldCalculator::accept()`
`299`	`299`	`}`
`300`	`300`	`else`
`301`	`301`	`{`
`302`		`- field.convertCompatible( value );`
	`302`	`+ ( void )field.convertCompatible( value );`
`303`	`303`	`mVectorLayer->changeAttributeValue( feature.id(), mAttributeId, value, newField ? emptyAttribute : feature.attributes().value( mAttributeId ) );`
`304`	`304`	`}`
`305`	`305`
Original file line number	Diff line number	Diff line change
`@@ -875,7 +875,7 @@ void QgsVectorLayerFeatureIterator::addExpressionAttribute( QgsFeature &f, int a`
`875`	`875`	`{`
`876`	`876`	`mExpressionContext->setFeature( f );`
`877`	`877`	`QVariant val = exp->evaluate( mExpressionContext.get() );`
`878`		`- mSource->mFields.at( attrIndex ).convertCompatible( val );`
	`878`	`+ ( void )mSource->mFields.at( attrIndex ).convertCompatible( val );`
`879`	`879`	`f.setAttribute( attrIndex, val );`
`880`	`880`	`}`
`881`	`881`	`else`
Original file line number	Diff line number	Diff line change
`@@ -141,9 +141,9 @@ void QgsRangeWidgetWrapper::initWidget( QWidget *editor )`
`141`	`141`	`}`
`142`	`142`	`else`
`143`	`143`	`{`
`144`		`- field().convertCompatible( min );`
`145`		`- field().convertCompatible( max );`
`146`		`- field().convertCompatible( step );`
	`144`	`+ ( void )field().convertCompatible( min );`
	`145`	`+ ( void )field().convertCompatible( max );`
	`146`	`+ ( void )field().convertCompatible( step );`
`147`	`147`	`if ( mQgsDial ) setupIntEditor( min, max, step, mQgsDial, this );`
`148`	`148`	`else if ( mQgsSlider ) setupIntEditor( min, max, step, mQgsSlider, this );`
`149`	`149`	`else if ( mDial ) setupIntEditor( min, max, step, mDial, this );`
Original file line number	Diff line number	Diff line change
`@@ -789,7 +789,7 @@ void TestQgsLayoutModel::proxyCrash()`
`789`	`789`	`layout->addLayoutItem( item3 );`
`790`	`790`
`791`	`791`	`// reorder items - expect no crash!`
`792`		`- layout->itemsModel()->reorderItemUp( item1 );`
	`792`	`+ ( void )layout->itemsModel()->reorderItemUp( item1 );`
`793`	`793`	`}`
`794`	`794`
`795`	`795`	`QGSTEST_MAIN( TestQgsLayoutModel )`