Skip to content

Commit a9074c2

Browse files
committedMar 19, 2013
fix some tests broken by vector API cleanup
1 parent eb87842 commit a9074c2

File tree

2 files changed

+6
-11
lines changed

2 files changed

+6
-11
lines changed
 

‎tests/src/python/test_qgsfeature.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,9 @@ def test_ValidFeature(self):
4141
myPath = os.path.join(unitTestDataPath(), 'points.shp')
4242
myLayer = QgsVectorLayer(myPath, 'Points', 'ogr')
4343
provider = myLayer.dataProvider()
44-
allAttrs = provider.attributeIndexes()
45-
myLayer.select(allAttrs)
46-
44+
fit = provider.getFeatures()
4745
feat = QgsFeature()
48-
myLayer.nextFeature(feat)
46+
fit.nextFeature(feat)
4947
myValidValue = feat.isValid()
5048
myMessage = '\nExpected: %s\nGot: %s' % ("True", myValidValue)
5149
assert myValidValue == True, myMessage
@@ -54,11 +52,9 @@ def test_Attributes(self):
5452
myPath = os.path.join(unitTestDataPath(), 'lines.shp')
5553
myLayer = QgsVectorLayer(myPath, 'Lines', 'ogr')
5654
provider = myLayer.dataProvider()
57-
allAttrs = provider.attributeIndexes()
58-
myLayer.select(allAttrs)
55+
fit = provider.getFeatures()
5956
feat = QgsFeature()
60-
myLayer.nextFeature(feat)
61-
57+
fit.nextFeature(feat)
6258
myAttributes = feat.attributes()
6359
myExpectedAttributes = [ QVariant("Highway"), QVariant(1) ]
6460

@@ -94,4 +90,3 @@ def test_SetGeometry(self):
9490

9591
if __name__ == '__main__':
9692
unittest.main()
97-

‎tests/src/python/test_qgsgeometry.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -302,10 +302,10 @@ def testClipping(self):
302302
)
303303
print 'Clip: %s' % myClipPolygon.exportToWkt()
304304
writeShape(myMemoryLayer, 'clipGeometryBefore.shp')
305-
myMemoryLayer.select(myProvider.attributeIndexes())
305+
fit = myProvider.getFeatures()
306306
myFeatures = []
307307
myFeature = QgsFeature()
308-
while myMemoryLayer.nextFeature(myFeature):
308+
while fit.nextFeature(myFeature):
309309
myGeometry = myFeature.geometry()
310310
if myGeometry.intersects(myClipPolygon):
311311
# Adds nodes where the clip and the line intersec

0 commit comments

Comments
 (0)
Please sign in to comment.