You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The problem is that you never know with shapefiles if they are multi or not, hence the idea of forcing multi.
Or do you have another idea how to handle this?
for any other sources than shapefiles, it is based on the layer definition. If layer is single, transformation is to single.
But for shapefiles, the multi-type is undefined, hence we need to force the conversion to multi. This does not cause any trouble since there is no distinction between single- and multi-line/polygon in the format. But, apparently, this is not the case for points. This commit is fixing the case for the points.
5 commit comments
3nids commentedon Sep 28, 2014
The problem is that you never know with shapefiles if they are multi or not, hence the idea of forcing multi.
Or do you have another idea how to handle this?
(backport to 2.4?)
NathanW2 commentedon Sep 28, 2014
So
destIsMulti
is not right with shapefiles?Forcing multi-type break copy and paste for point files so I don't think we should force it here.
3nids commentedon Sep 29, 2014
yes, your fix seems perfect to me.
pcav commentedon Sep 29, 2014
IMHO the default shouold be POINT, not MULTIPOINT, used only in very specialized cases. Multipoints are really a PITA, almost always.
3nids commentedon Sep 29, 2014
for any other sources than shapefiles, it is based on the layer definition. If layer is single, transformation is to single.
But for shapefiles, the multi-type is undefined, hence we need to force the conversion to multi. This does not cause any trouble since there is no distinction between single- and multi-line/polygon in the format. But, apparently, this is not the case for points. This commit is fixing the case for the points.