Add test that python exception is caught when executing an alg

nyalldawson · nyalldawson · commit a8cdde5232ed · 2017-06-23T12:08:54.000+10:00
diff --git a/python/plugins/processing/tests/QgisAlgorithmsTest.py b/python/plugins/processing/tests/QgisAlgorithmsTest.py
@@ -30,7 +30,28 @@
 import nose2
 import shutil
 
+from qgis.core import (QgsProcessingAlgorithm,
+                       QgsProcessingFeedback)
 from qgis.testing import start_app, unittest
+from processing.core.GeoAlgorithmExecutionException import GeoAlgorithmExecutionException
+from processing.tools.dataobjects import createContext
+
+
+class TestAlg(QgsProcessingAlgorithm):
+
+    def __init__(self):
+        super().__init__()
+
+    def name(self):
+        return 'testalg'
+
+    def displayName(self):
+        return 'testalg'
+
+    def processAlgorithm(self, parameters, context, feedback):
+        raise GeoAlgorithmExecutionException(
+            self.tr('Exception while processing'))
+        return {}
 
 
 class TestQgisAlgorithms(unittest.TestCase, AlgorithmsTestBase.AlgorithmsTest):
@@ -52,6 +73,17 @@ def tearDownClass(cls):
     def test_definition_file(self):
         return 'qgis_algorithm_tests.yaml'
 
+    def testProcessingException(self):
+        """
+        Test that Python exception is caught when running an alg
+        """
+
+        alg = TestAlg()
+        context = createContext()
+        feedback = QgsProcessingFeedback()
+        results, ok = alg.run({}, context, feedback)
+        self.assertFalse(ok)
+
 
 if __name__ == '__main__':
     nose2.main()
diff --git a/python/plugins/processing/tools/dataobjects.py b/python/plugins/processing/tools/dataobjects.py
@@ -65,7 +65,7 @@
 TYPE_TABLE = 5
 
 
-def createContext(feedback):
+def createContext(feedback=None):
     """
     Creates a default processing context
     """
