Don't highlight whole polygon in red when using map label tools

For polygons, we don't want to fill the whole polygon itself with the rubber band as that obscures too much of the map and prevents users from getting a good view of the underlying map. Instead, just use the boundary of the polygon for the rubber band. That's enough to give a visual indicator of the feature associated with the label without getting in the way. (cherry picked from commit 235fee1)
qgis · Dec 18, 2019 · a8cd06a · a8cd06a
1 parent 469a66a
commit a8cd06a
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/src/app/qgsmaptoollabel.cpp b/src/app/qgsmaptoollabel.cpp
@@ -132,6 +132,14 @@ void QgsMapToolLabel::createRubberBands()
       QgsGeometry geom = f.geometry();
       if ( !geom.isNull() )
       {
+        if ( geom.type() == QgsWkbTypes::PolygonGeometry )
+        {
+          // for polygons, we don't want to fill the whole polygon itself with the rubber band
+          // as that obscures too much of the map and prevents users from getting a good view of
+          // the underlying map
+          // instead, just use the boundary of the polygon for the rubber band
+          geom = QgsGeometry( geom.constGet()->boundary() );
+        }
         QgsSettings settings;
         int r = settings.value( QStringLiteral( "qgis/digitizing/line_color_red" ), 255 ).toInt();
         int g = settings.value( QStringLiteral( "qgis/digitizing/line_color_green" ), 0 ).toInt();