Fix warnings in pdal_wrench

qgis · Apr 14, 2023 · a87908d · a87908d
1 parent cc094fb
commit a87908d
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 5 deletions.
diff --git a/external/pdal_wrench/alg.cpp b/external/pdal_wrench/alg.cpp
@@ -120,7 +120,7 @@ bool Alg::parseArgs(std::vector<std::string> args)
         {
             parseBounds(filterBounds);
         }
-        catch (pdal::Bounds::error err)
+        catch (pdal::Bounds::error& err)
         {
             std::cerr << "invalid bounds: " << err.what() << std::endl;
             return false;

diff --git a/external/pdal_wrench/density.cpp b/external/pdal_wrench/density.cpp
@@ -294,7 +294,7 @@ void Density::preparePipelines(std::vector<std::unique_ptr<PipelineManager>>& pi
 }
 
 
-void Density::finalize(std::vector<std::unique_ptr<PipelineManager>>& pipelines)
+void Density::finalize(std::vector<std::unique_ptr<PipelineManager>>&)
 {
     if (!tileOutputFiles.empty())
     {

diff --git a/external/pdal_wrench/to_raster.cpp b/external/pdal_wrench/to_raster.cpp
@@ -317,7 +317,7 @@ void ToRaster::preparePipelines(std::vector<std::unique_ptr<PipelineManager>>& p
 }
 
 
-void ToRaster::finalize(std::vector<std::unique_ptr<PipelineManager>>& pipelines)
+void ToRaster::finalize(std::vector<std::unique_ptr<PipelineManager>>&)
 {
     if (!tileOutputFiles.empty())
     {

diff --git a/external/pdal_wrench/to_raster_tin.cpp b/external/pdal_wrench/to_raster_tin.cpp
@@ -313,7 +313,7 @@ void ToRasterTin::preparePipelines(std::vector<std::unique_ptr<PipelineManager>>
     }
 }
 
-void ToRasterTin::finalize(std::vector<std::unique_ptr<PipelineManager>>& pipelines)
+void ToRasterTin::finalize(std::vector<std::unique_ptr<PipelineManager>>& )
 {
     if (!tileOutputFiles.empty())
     {

diff --git a/external/pdal_wrench/translate.cpp b/external/pdal_wrench/translate.cpp
@@ -142,7 +142,7 @@ static std::unique_ptr<PipelineManager> pipeline(ParallelJobInfo *tile, std::str
         writer_opts.add(pdal::Option("offset_z", "auto"));
     }
 
-    Stage& w = manager->makeWriter( tile->outputFilename, "", *last, writer_opts);
+    (void)manager->makeWriter( tile->outputFilename, "", *last, writer_opts);
 
     return manager;
 }

diff --git a/external/pdal_wrench/vpc.cpp b/external/pdal_wrench/vpc.cpp
@@ -569,6 +569,7 @@ void buildVpc(std::vector<std::string> args)
             pdal::Options writer_opts;
             //writer_opts.add(pdal::Option("forward", "all"));
             Stage& writer = manager->makeWriter(overviewFilenameCopc, "writers.copc", merge, writer_opts);
+            (void)writer;
 
             for (const std::string &overviewTempFile : overviewTempFiles)
             {