fix clang-tidy

vcloarec · vcloarec · commit a82da052d609 · 2023-03-18T23:56:18.000-04:00
diff --git a/src/app/mesh/qgsmaptooleditmeshframe.cpp b/src/app/mesh/qgsmaptooleditmeshframe.cpp
@@ -1626,7 +1626,7 @@ bool QgsMapToolEditMeshFrame::isFaceSelected( int faceIndex )
   return true;
 }
 
-void QgsMapToolEditMeshFrame::setSelectedVertices( const QList<int> newSelectedVertices, Qgis::SelectBehavior behavior )
+void QgsMapToolEditMeshFrame::setSelectedVertices( const QList<int> &newSelectedVertices, Qgis::SelectBehavior behavior )
 {
   if ( mSelectedVertices.isEmpty() )
   {
@@ -1662,7 +1662,7 @@ void QgsMapToolEditMeshFrame::setSelectedVertices( const QList<int> newSelectedV
   prepareSelection();
 }
 
-void QgsMapToolEditMeshFrame::setSelectedFaces( const QList<int> newSelectedFaces, Qgis::SelectBehavior behavior )
+void QgsMapToolEditMeshFrame::setSelectedFaces( const QList<int> &newSelectedFaces, Qgis::SelectBehavior behavior )
 {
   bool removeFaces = false;
 
@@ -1948,7 +1948,6 @@ void QgsMapToolEditMeshFrame::onUndoRedo()
       mCadDockWidget->setEnabledZ( mCadDockWidget->cadEnabled() );
       break;
     case ForceByLines:
-      break;
     case Selecting:
     case SelectingByPolygon:
       break;
diff --git a/src/app/mesh/qgsmaptooleditmeshframe.h b/src/app/mesh/qgsmaptooleditmeshframe.h
@@ -229,8 +229,8 @@ class APP_EXPORT QgsMapToolEditMeshFrame : public QgsMapToolAdvancedDigitizing
     void addNewSelectedVertex( int vertexIndex );
     void removeFromSelection( int vertexIndex );
     bool isFaceSelected( int faceIndex );
-    void setSelectedVertices( const QList<int> newSelectedVertices,  Qgis::SelectBehavior behavior );
-    void setSelectedFaces( const QList<int> newSelectedFaces,  Qgis::SelectBehavior behavior );
+    void setSelectedVertices( const QList<int> &newSelectedVertices,  Qgis::SelectBehavior behavior );
+    void setSelectedFaces( const QList<int> &newSelectedFaces,  Qgis::SelectBehavior behavior );
     void selectByGeometry( const QgsGeometry &geometry,  Qt::KeyboardModifiers modifiers );
     void selectTouchedByGeometry( const QgsGeometry &geometry, Qgis::SelectBehavior behavior );
     void selectContainedByGeometry( const QgsGeometry &geometry, Qgis::SelectBehavior behavior );

Original file line number	Diff line number	Diff line change
`@@ -1626,7 +1626,7 @@ bool QgsMapToolEditMeshFrame::isFaceSelected( int faceIndex )`
`1626`	`1626`	`return true;`
`1627`	`1627`	`}`
`1628`	`1628`
`1629`		`-void QgsMapToolEditMeshFrame::setSelectedVertices( const QList<int> newSelectedVertices, Qgis::SelectBehavior behavior )`
	`1629`	`+void QgsMapToolEditMeshFrame::setSelectedVertices( const QList<int> &newSelectedVertices, Qgis::SelectBehavior behavior )`
`1630`	`1630`	`{`
`1631`	`1631`	`if ( mSelectedVertices.isEmpty() )`
`1632`	`1632`	`{`
`@@ -1662,7 +1662,7 @@ void QgsMapToolEditMeshFrame::setSelectedVertices( const QList<int> newSelectedV`
`1662`	`1662`	`prepareSelection();`
`1663`	`1663`	`}`
`1664`	`1664`
`1665`		`-void QgsMapToolEditMeshFrame::setSelectedFaces( const QList<int> newSelectedFaces, Qgis::SelectBehavior behavior )`
	`1665`	`+void QgsMapToolEditMeshFrame::setSelectedFaces( const QList<int> &newSelectedFaces, Qgis::SelectBehavior behavior )`
`1666`	`1666`	`{`
`1667`	`1667`	`bool removeFaces = false;`
`1668`	`1668`
`@@ -1948,7 +1948,6 @@ void QgsMapToolEditMeshFrame::onUndoRedo()`
`1948`	`1948`	`mCadDockWidget->setEnabledZ( mCadDockWidget->cadEnabled() );`
`1949`	`1949`	`break;`
`1950`	`1950`	`case ForceByLines:`
`1951`		`- break;`
`1952`	`1951`	`case Selecting:`
`1953`	`1952`	`case SelectingByPolygon:`
`1954`	`1953`	`break;`