Avoid prepare-commit script leaving temporary .diff files

nyalldawson · nyalldawson · commit a7aec56619a1 · 2018-06-30T09:20:43.000+10:00
(cherry-picked from 821241e)
diff --git a/scripts/prepare-commit.sh b/scripts/prepare-commit.sh
@@ -59,10 +59,11 @@ fi
 
 if [[ -n "$QGIS_CHECK_SPELLING" && -x "${TOPLEVEL}"/scripts/spell_check/check_spelling.sh ]]; then "${TOPLEVEL}"/scripts/spell_check/check_spelling.sh "$MODIFIED"; fi
 
+FILES_CHANGED=0
 
 # save original changes
 REV=$(git log -n1 --pretty=%H)
-git diff >sha-"$REV".diff
+#git diff >sha-"$REV".diff
 
 ASTYLEDIFF=astyle.$REV.diff
 true > "$ASTYLEDIFF"
@@ -101,9 +102,11 @@ if [ -s "$ASTYLEDIFF" ]; then
   if tty -s; then
     # review astyle changes
     colordiff <"$ASTYLEDIFF" | less -r
+    rm "$ASTYLEDIFF"
   else
     echo "Files changed (see $ASTYLEDIFF)"
   fi
+  FILES_CHANGED=1
 else
   rm "$ASTYLEDIFF"
 fi
@@ -136,17 +139,15 @@ if [[ -s "$SIPIFYDIFF" ]]; then
   if tty -s; then
     # review astyle changes
     colordiff <"$SIPIFYDIFF" | less -r
+    rm "$SIPIFYDIFF"
   else
     echo "Files changed (see $ASTYLEDIFF)"
   fi
-  exit 1
+  FILES_CHANGED=1
 else
   rm "$SIPIFYDIFF"
 fi
-if [ -s "$ASTYLEDIFF" ]; then
-    exit 1
-fi
 
-exit 0
+exit $FILES_CHANGED
 
 # vim: set ts=2 expandtab :
