Fix crash when snapping to curved geometry without curved segments

When a geometry that supports curves has only straight segments and a user snaps to it with "snap to intersections" enabled, QGIS crashes. Fixes #33234
qgis · Oct 13, 2020 · a72d84a · a72d84a
1 parent a3d6965
commit a72d84a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/core/qgspointlocator.cpp b/src/core/qgspointlocator.cpp
@@ -466,8 +466,10 @@ static QgsPointLocator::MatchList _geometrySegmentsInRect( QgsGeometry *geom, co
   for ( auto part = straightGeom.const_parts_begin(); part != straightGeom.const_parts_end(); ++part )
   {
     // Checking for invalid linestrings
-    // A linestring should/(must?) have at least two points
-    if ( qgsgeometry_cast<QgsLineString *>( *part )->numPoints() < 2 )
+    // A linestring should/(must?) have at least two points.
+    QgsCurve *curve = qgsgeometry_cast<QgsCurve *>( *part );
+    Q_ASSERT( !curve->hasCurvedSegments() );
+    if ( curve->numPoints() < 2 )
       continue;
 
     QgsAbstractGeometry::vertex_iterator it = ( *part )->vertices_begin();