Fix displacement symbols with data defined properties (fix #9601)

nyalldawson · nyalldawson · commit a6f96ba51b73 · 2016-06-16T23:03:31.000+10:00
Previously only the attributes of the first feature were being
used to render the points inside a group
diff --git a/src/core/symbology-ng/qgspointdisplacementrenderer.cpp b/src/core/symbology-ng/qgspointdisplacementrenderer.cpp
@@ -157,13 +157,15 @@ void QgsPointDisplacementRenderer::drawGroup( const DisplacementGroup& group, Qg
 
   //get list of labels and symbols
   QStringList labelAttributeList;
-  QList<QgsMarkerSymbolV2*> symbolList;
+  QList< QgsMarkerSymbolV2* > symbolList;
+  QgsFeatureList featureList;
 
   QgsMultiPointV2* groupMultiPoint = new QgsMultiPointV2();
   for ( DisplacementGroup::const_iterator attIt = group.constBegin(); attIt != group.constEnd(); ++attIt )
   {
     labelAttributeList << ( mDrawLabels ? getLabel( attIt.value().first ) : QString() );
     symbolList << dynamic_cast<QgsMarkerSymbolV2*>( attIt.value().second );
+    featureList << attIt.value().first;
     groupMultiPoint->addGeometry( attIt.value().first.constGeometry()->geometry()->clone() );
   }
 
@@ -212,7 +214,7 @@ void QgsPointDisplacementRenderer::drawGroup( const DisplacementGroup& group, Qg
   }
 
   //draw symbols on the circle
-  drawSymbols( feature, context, symbolList, symbolPositions, selected );
+  drawSymbols( featureList, context, symbolList, symbolPositions, selected );
   //and also the labels
   drawLabels( pt, symbolContext, labelPositions, labelAttributeList );
 }
@@ -621,15 +623,21 @@ void QgsPointDisplacementRenderer::drawCircle( double radiusPainterUnits, QgsSym
   p->drawArc( QRectF( centerPoint.x() - radiusPainterUnits, centerPoint.y() - radiusPainterUnits, 2 * radiusPainterUnits, 2 * radiusPainterUnits ), 0, 5760 );
 }
 
-void QgsPointDisplacementRenderer::drawSymbols( const QgsFeature& f, QgsRenderContext& context, const QList<QgsMarkerSymbolV2*>& symbolList, const QList<QPointF>& symbolPositions, bool selected )
+void QgsPointDisplacementRenderer::drawSymbols( const QgsFeatureList& features, QgsRenderContext& context,
+    const QList< QgsMarkerSymbolV2* >& symbolList, const QList<QPointF>& symbolPositions, bool selected )
 {
   QList<QPointF>::const_iterator symbolPosIt = symbolPositions.constBegin();
   QList<QgsMarkerSymbolV2*>::const_iterator symbolIt = symbolList.constBegin();
-  for ( ; symbolPosIt != symbolPositions.constEnd() && symbolIt != symbolList.constEnd(); ++symbolPosIt, ++symbolIt )
+  QgsFeatureList::const_iterator featIt = features.constBegin();
+  for ( ; symbolPosIt != symbolPositions.constEnd() && symbolIt != symbolList.constEnd() && featIt != features.constEnd();
+        ++symbolPosIt, ++symbolIt, ++featIt )
   {
     if ( *symbolIt )
     {
-      ( *symbolIt )->renderPoint( *symbolPosIt, &f, context, -1, selected );
+      context.expressionContext().setFeature( *featIt );
+      ( *symbolIt )->startRender( context );
+      ( *symbolIt )->renderPoint( *symbolPosIt, &( *featIt ), context, -1, selected );
+      ( *symbolIt )->stopRender( context );
     }
   }
 }
diff --git a/src/core/symbology-ng/qgspointdisplacementrenderer.h b/src/core/symbology-ng/qgspointdisplacementrenderer.h
@@ -235,7 +235,7 @@ class CORE_EXPORT QgsPointDisplacementRenderer: public QgsFeatureRendererV2
     QMap<QgsFeatureId, int> mGroupIndex;
     /** Spatial index for fast lookup of close points*/
     QgsSpatialIndex* mSpatialIndex;
-    /** Keeps trask which features are selected */
+    /** Keeps track which features are selected */
     QSet<QgsFeatureId> mSelectedFeatures;
 
     /** Creates a search rectangle with specified distance tolerance */
@@ -254,7 +254,7 @@ class CORE_EXPORT QgsPointDisplacementRenderer: public QgsFeatureRendererV2
     void calculateSymbolAndLabelPositions( QgsSymbolV2RenderContext &symbolContext, QPointF centerPoint, int nPosition, double symbolDiagonal, QList<QPointF>& symbolPositions, QList<QPointF>& labelShifts , double &circleRadius ) const;
     void drawGroup( const DisplacementGroup& group, QgsRenderContext& context );
     void drawCircle( double radiusPainterUnits, QgsSymbolV2RenderContext& context, QPointF centerPoint, int nSymbols );
-    void drawSymbols( const QgsFeature& f, QgsRenderContext& context, const QList<QgsMarkerSymbolV2*>& symbolList, const QList<QPointF>& symbolPositions, bool selected = false );
+    void drawSymbols( const QgsFeatureList& features, QgsRenderContext& context, const QList< QgsMarkerSymbolV2* >& symbolList, const QList<QPointF>& symbolPositions, bool selected = false );
     void drawLabels( QPointF centerPoint, QgsSymbolV2RenderContext& context, const QList<QPointF>& labelShifts, const QStringList& labelList );
     /** Returns first symbol for feature or 0 if none*/
     QgsSymbolV2* firstSymbolForFeature( QgsFeatureRendererV2* r, QgsFeature& f, QgsRenderContext& context );

Original file line number	Diff line number	Diff line change
`@@ -157,13 +157,15 @@ void QgsPointDisplacementRenderer::drawGroup( const DisplacementGroup& group, Qg`
`157`	`157`
`158`	`158`	`//get list of labels and symbols`
`159`	`159`	`QStringList labelAttributeList;`
`160`		`- QList<QgsMarkerSymbolV2*> symbolList;`
	`160`	`+ QList< QgsMarkerSymbolV2* > symbolList;`
	`161`	`+ QgsFeatureList featureList;`
`161`	`162`
`162`	`163`	`QgsMultiPointV2* groupMultiPoint = new QgsMultiPointV2();`
`163`	`164`	`for ( DisplacementGroup::const_iterator attIt = group.constBegin(); attIt != group.constEnd(); ++attIt )`
`164`	`165`	`{`
`165`	`166`	`labelAttributeList << ( mDrawLabels ? getLabel( attIt.value().first ) : QString() );`
`166`	`167`	`symbolList << dynamic_cast<QgsMarkerSymbolV2*>( attIt.value().second );`
	`168`	`+ featureList << attIt.value().first;`
`167`	`169`	`groupMultiPoint->addGeometry( attIt.value().first.constGeometry()->geometry()->clone() );`
`168`	`170`	`}`
`169`	`171`
`@@ -212,7 +214,7 @@ void QgsPointDisplacementRenderer::drawGroup( const DisplacementGroup& group, Qg`
`212`	`214`	`}`
`213`	`215`
`214`	`216`	`//draw symbols on the circle`
`215`		`- drawSymbols( feature, context, symbolList, symbolPositions, selected );`
	`217`	`+ drawSymbols( featureList, context, symbolList, symbolPositions, selected );`
`216`	`218`	`//and also the labels`
`217`	`219`	`drawLabels( pt, symbolContext, labelPositions, labelAttributeList );`
`218`	`220`	`}`
`@@ -621,15 +623,21 @@ void QgsPointDisplacementRenderer::drawCircle( double radiusPainterUnits, QgsSym`
`621`	`623`	`p->drawArc( QRectF( centerPoint.x() - radiusPainterUnits, centerPoint.y() - radiusPainterUnits, 2 * radiusPainterUnits, 2 * radiusPainterUnits ), 0, 5760 );`
`622`	`624`	`}`
`623`	`625`
`624`		`-void QgsPointDisplacementRenderer::drawSymbols( const QgsFeature& f, QgsRenderContext& context, const QList<QgsMarkerSymbolV2*>& symbolList, const QList<QPointF>& symbolPositions, bool selected )`
	`626`	`+void QgsPointDisplacementRenderer::drawSymbols( const QgsFeatureList& features, QgsRenderContext& context,`
	`627`	`+ const QList< QgsMarkerSymbolV2* >& symbolList, const QList<QPointF>& symbolPositions, bool selected )`
`625`	`628`	`{`
`626`	`629`	`QList<QPointF>::const_iterator symbolPosIt = symbolPositions.constBegin();`
`627`	`630`	`QList<QgsMarkerSymbolV2*>::const_iterator symbolIt = symbolList.constBegin();`
`628`		`- for ( ; symbolPosIt != symbolPositions.constEnd() && symbolIt != symbolList.constEnd(); ++symbolPosIt, ++symbolIt )`
	`631`	`+ QgsFeatureList::const_iterator featIt = features.constBegin();`
	`632`	`+ for ( ; symbolPosIt != symbolPositions.constEnd() && symbolIt != symbolList.constEnd() && featIt != features.constEnd();`
	`633`	`+ ++symbolPosIt, ++symbolIt, ++featIt )`
`629`	`634`	`{`
`630`	`635`	`if ( *symbolIt )`
`631`	`636`	`{`
`632`		`- ( symbolIt )->renderPoint( symbolPosIt, &f, context, -1, selected );`
	`637`	`+ context.expressionContext().setFeature( *featIt );`
	`638`	`+ ( *symbolIt )->startRender( context );`
	`639`	`+ ( symbolIt )->renderPoint( symbolPosIt, &( *featIt ), context, -1, selected );`
	`640`	`+ ( *symbolIt )->stopRender( context );`
`633`	`641`	`}`
`634`	`642`	`}`
`635`	`643`	`}`