Fix "Set Project CRS from Layer" action in layer right click menu

resets layer to have no CRS after changing the project CRS
qgis · Sep 23, 2020 · a674cb7 · a674cb7
1 parent bddd3ed
commit a674cb7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/app/qgsapplayertreeviewmenuprovider.cpp b/src/app/qgsapplayertreeviewmenuprovider.cpp
@@ -349,13 +349,17 @@ QMenu *QgsAppLayerTreeViewMenuProvider::createContextMenu()
           {
             QAction *action = menuSetCRS->addAction( tr( "Set to %1" ).arg( crs.userFriendlyIdentifier( QgsCoordinateReferenceSystem::ShortString ) ) );
             action->setProperty( "crs", crs.toWkt( QgsCoordinateReferenceSystem::WKT_PREFERRED ) );
+
+            connect( action, &QAction::triggered, this, [ = ]
+            {
+              setLayerCrs( crs );
+            } );
+
             i++;
             if ( i == 2 )
               break;
           }
         }
-        // Connect once for the entire submenu.
-        connect( menuSetCRS, &QMenu::triggered, this, &QgsAppLayerTreeViewMenuProvider::setLayerCrs );
 
         // set layer crs
         menuSetCRS->addSeparator();
@@ -1023,11 +1027,8 @@ bool QgsAppLayerTreeViewMenuProvider::removeActionEnabled()
   return true;
 }
 
-void QgsAppLayerTreeViewMenuProvider::setLayerCrs( QAction *action )
+void QgsAppLayerTreeViewMenuProvider::setLayerCrs( const QgsCoordinateReferenceSystem &crs )
 {
-  const QString wkt = action->property( "crs" ).toString();
-  const QgsCoordinateReferenceSystem crs = QgsCoordinateReferenceSystem( wkt );
-
   const auto constSelectedNodes = mView->selectedNodes();
   for ( QgsLayerTreeNode *node : constSelectedNodes )
   {

diff --git a/src/app/qgsapplayertreeviewmenuprovider.h b/src/app/qgsapplayertreeviewmenuprovider.h
@@ -71,8 +71,7 @@ class QgsAppLayerTreeViewMenuProvider : public QObject, public QgsLayerTreeViewM
     void copySymbolLegendNodeSymbol( const QString &layerId, const QString &ruleKey );
     void pasteSymbolLegendNodeSymbol( const QString &layerId, const QString &ruleKey );
     void setSymbolLegendNodeColor( const QColor &color );
-    // Set layer CRS corresponding to the text of the given action
-    void setLayerCrs( QAction *action );
+    void setLayerCrs( const QgsCoordinateReferenceSystem &crs );
   private:
     bool removeActionEnabled();
 };