[pyqgis-console] a simple syntax checker for the editor

- some fixes and code cleanup
qgis · May 11, 2013 · a60e74a · a60e74a
1 parent adb2653
commit a60e74a
Show file tree

Hide file tree

Showing 4 changed files with 140 additions and 74 deletions.
diff --git a/images/images.qrc b/images/images.qrc
@@ -102,6 +102,7 @@
         <file>themes/default/console/iconSearchEditorConsole.png</file>
         <file>themes/default/console/iconSearchNextEditorConsole.png</file>
         <file>themes/default/console/iconSearchPrevEditorConsole.png</file>
+        <file>themes/default/console/iconSyntaxErrorConsole.png</file>
         <file>themes/default/extents.png</file>
         <file>themes/default/favourites.png</file>
         <file>themes/default/geographic.png</file>

diff --git a/images/themes/default/console/iconSyntaxErrorConsole.png b/images/themes/default/console/iconSyntaxErrorConsole.png
diff --git a/python/console/console.py b/python/console/console.py
@@ -160,7 +160,7 @@ def __init__(self, parent=None):
         saveFileBt = QCoreApplication.translate("PythonConsole", "Save")
         self.saveFileButton = QAction(self)
         self.saveFileButton.setCheckable(False)
-        self.saveFileButton.setEnabled(True)
+        self.saveFileButton.setEnabled(False)
         self.saveFileButton.setIcon(QgsApplication.getThemeIcon("console/iconSaveConsole.png"))
         self.saveFileButton.setMenuRole(QAction.PreferencesRole)
         self.saveFileButton.setIconVisibleInMenu(True)
@@ -537,6 +537,11 @@ def _textFindChanged(self):
             self.findPrevButton.setEnabled(False)
 
     def onClickGoToLine(self, item, column):
+        if item.text(1) == 'syntaxError':
+            check = self.tabEditorWidget.currentWidget().newEditor.syntaxCheck()
+            if check:
+                self.tabEditorWidget.currentWidget().save()
+            return
         linenr = int(item.text(1))
         itemName = str(item.text(0))
         charPos = itemName.find(' ')