[auth] Check for empty credentials instead of null

elpaso · elpaso · commit a4a33dff75fe · 2017-10-06T16:33:53.000+02:00
diff --git a/src/providers/wms/qgswmscapabilities.h b/src/providers/wms/qgswmscapabilities.h
@@ -502,12 +502,12 @@ struct QgsWmsAuthorization
     {
       return QgsAuthManager::instance()->updateNetworkRequest( request, mAuthCfg );
     }
-    else if ( !mUserName.isNull() || !mPassword.isNull() )
+    else if ( !mUserName.isEmpty() || !mPassword.isEmpty() )
     {
       request.setRawHeader( "Authorization", "Basic " + QStringLiteral( "%1:%2" ).arg( mUserName, mPassword ).toLatin1().toBase64() );
     }
 
-    if ( !mReferer.isNull() )
+    if ( !mReferer.isEmpty() )
     {
       request.setRawHeader( "Referer", QStringLiteral( "%1" ).arg( mReferer ).toLatin1() );
     }

Original file line number	Diff line number	Diff line change
`@@ -502,12 +502,12 @@ struct QgsWmsAuthorization`
`502`	`502`	`{`
`503`	`503`	`return QgsAuthManager::instance()->updateNetworkRequest( request, mAuthCfg );`
`504`	`504`	`}`
`505`		`- else if ( !mUserName.isNull() \|\| !mPassword.isNull() )`
	`505`	`+ else if ( !mUserName.isEmpty() \|\| !mPassword.isEmpty() )`
`506`	`506`	`{`
`507`	`507`	`request.setRawHeader( "Authorization", "Basic " + QStringLiteral( "%1:%2" ).arg( mUserName, mPassword ).toLatin1().toBase64() );`
`508`	`508`	`}`
`509`	`509`
`510`		`- if ( !mReferer.isNull() )`
	`510`	`+ if ( !mReferer.isEmpty() )`
`511`	`511`	`{`
`512`	`512`	`request.setRawHeader( "Referer", QStringLiteral( "%1" ).arg( mReferer ).toLatin1() );`
`513`	`513`	`}`