Add tests for opening and applying layer properties for valid

and invalid layers of all layer subclasses (cherry picked from commit 0250065)
qgis · Oct 6, 2023 · a45152e · a45152e
1 parent aa12b87
commit a45152e
Show file tree

Hide file tree

Showing 4 changed files with 230 additions and 2 deletions.
diff --git a/src/app/annotations/qgsannotationlayerproperties.h b/src/app/annotations/qgsannotationlayerproperties.h
@@ -23,6 +23,7 @@
 #include "qgsmaplayerstylemanager.h"
 
 #include "qgsannotationlayer.h"
+#include "qgis_app.h"
 
 class QgsMapLayer;
 class QgsMapCanvas;
@@ -33,7 +34,7 @@ class QgsMapLayerConfigWidgetFactory;
 class QgsMapLayerConfigWidget;
 
 
-class QgsAnnotationLayerProperties : public QgsOptionsDialogBase, private Ui::QgsAnnotationLayerPropertiesBase
+class APP_EXPORT QgsAnnotationLayerProperties : public QgsOptionsDialogBase, private Ui::QgsAnnotationLayerPropertiesBase
 {
     Q_OBJECT
   public:

diff --git a/src/app/pointcloud/qgspointcloudlayerproperties.h b/src/app/pointcloud/qgspointcloudlayerproperties.h
@@ -23,6 +23,7 @@
 #include "qgsmaplayerstylemanager.h"
 #include <QAbstractTableModel>
 
+#include "qgis_app.h"
 #include "qgspointcloudlayer.h"
 
 class QgsMapLayer;
@@ -88,7 +89,7 @@ class QgsPointCloudClassificationStatisticsModel : public QAbstractTableModel
     QList<int> mClassifications;
 };
 
-class QgsPointCloudLayerProperties : public QgsOptionsDialogBase, private Ui::QgsPointCloudLayerPropertiesBase
+class APP_EXPORT QgsPointCloudLayerProperties : public QgsOptionsDialogBase, private Ui::QgsPointCloudLayerPropertiesBase
 {
     Q_OBJECT
   public:

diff --git a/tests/src/app/CMakeLists.txt b/tests/src/app/CMakeLists.txt
@@ -18,6 +18,7 @@ set(TESTS
   testqgsapplocatorfilters.cpp
   testqgsdecorationscalebar.cpp
   testqgsfieldcalculator.cpp
+  testqgslayerpropertiesdialogs.cpp
   testqgsmapcanvasdockwidget.cpp
   testqgsmaptooleditannotation.cpp
   testqgsmaptoolidentifyaction.cpp

diff --git a/tests/src/app/testqgslayerpropertiesdialogs.cpp b/tests/src/app/testqgslayerpropertiesdialogs.cpp
@@ -0,0 +1,225 @@
+/***************************************************************************
+     testqgslayerpropertiesdialogs.cpp
+     ------------------------------
+    Date                 : October 2023
+    Copyright            : (C) 2023 by Nyall Dawson
+    Email                : nyall dot dawson at gmail dot com
+ ***************************************************************************
+ *                                                                         *
+ *   This program is free software; you can redistribute it and/or modify  *
+ *   it under the terms of the GNU General Public License as published by  *
+ *   the Free Software Foundation; either version 2 of the License, or     *
+ *   (at your option) any later version.                                   *
+ *                                                                         *
+ ***************************************************************************/
+
+#include "qgstest.h"
+#include <QObject>
+
+#include "qgisapp.h"
+#include "qgsapplication.h"
+#include "qgsmapcanvas.h"
+#include "qgsmessagebar.h"
+#include "qgsvectorlayer.h"
+#include "qgsvectorlayerproperties.h"
+#include "qgsrasterlayer.h"
+#include "qgsrasterlayerproperties.h"
+#include "qgsmeshlayer.h"
+#include "qgsmeshlayerproperties.h"
+#include "qgspointcloudlayer.h"
+#include "qgspointcloudlayerproperties.h"
+#include "qgsvectortilelayer.h"
+#include "qgsvectortilelayerproperties.h"
+#include "qgsannotationlayer.h"
+#include "annotations/qgsannotationlayerproperties.h"
+
+class TestQgsLayerPropertiesDialogs : public QgsTest
+{
+    Q_OBJECT
+
+  public:
+    TestQgsLayerPropertiesDialogs()
+      : QgsTest( QStringLiteral( "Layer properties dialogs" ) )
+    {}
+
+  private:
+    QString mTestDataDir;
+    QgisApp *mQgisApp = nullptr;
+
+  private slots:
+
+    void initTestCase()
+    {
+      QgsApplication::init();
+      QgsApplication::initQgis();
+      mQgisApp = new QgisApp();
+
+      const QString myDataDir( TEST_DATA_DIR );
+      mTestDataDir = myDataDir + '/';
+    }
+
+    void cleanupTestCase()
+    {
+      QgsApplication::exitQgis();
+    }
+
+    void testValidVectorProperties()
+    {
+      // valid vector layer
+      const QString pointFileName = mTestDataDir + "points.shp";
+      const QFileInfo pointFileInfo( pointFileName );
+      std::unique_ptr< QgsVectorLayer > vl = std::make_unique< QgsVectorLayer >( pointFileInfo.filePath(),
+                                             pointFileInfo.completeBaseName(), QStringLiteral( "ogr" ) );
+      QVERIFY( vl->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsVectorLayerProperties dialog( &canvas, &messageBar, vl.get() );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testInvalidVectorProperties()
+    {
+      // invalid vector layer
+      const QString pointFileName = mTestDataDir + "xxpoints.shp";
+      const QFileInfo pointFileInfo( pointFileName );
+      std::unique_ptr< QgsVectorLayer > vl = std::make_unique< QgsVectorLayer >( pointFileInfo.filePath(),
+                                             pointFileInfo.completeBaseName(), QStringLiteral( "xxogr" ) );
+      QVERIFY( !vl->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsVectorLayerProperties dialog( &canvas, &messageBar, vl.get() );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testValidRasterProperties()
+    {
+      // valid raster layer
+      QTemporaryDir tmpDir;
+      QFile::copy( mTestDataDir + "landsat_4326.tif", tmpDir.filePath( QStringLiteral( "landsat_4326.tif" ) ) );
+      const QString rasterFileName = tmpDir.filePath( QStringLiteral( "landsat_4326.tif" ) );
+      std::unique_ptr< QgsRasterLayer > rl = std::make_unique< QgsRasterLayer >( rasterFileName, QStringLiteral( "test" ), QStringLiteral( "gdal" ) );
+      QVERIFY( rl->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsRasterLayerProperties dialog( rl.get(), &canvas );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testInvalidRasterProperties()
+    {
+      // invalid raster layer
+      const QString rasterFileName = mTestDataDir + "xxlandsat_4326.tif";
+      std::unique_ptr< QgsRasterLayer > rl = std::make_unique< QgsRasterLayer >( rasterFileName, QStringLiteral( "test" ), QStringLiteral( "xxgdal" ) );
+      QVERIFY( !rl->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsRasterLayerProperties dialog( rl.get(), &canvas );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testValidMeshProperties()
+    {
+      // valid mesh layer
+      QString uri( mTestDataDir + "/mesh/quad_and_triangle.2dm" );
+      std::unique_ptr< QgsMeshLayer > ml = std::make_unique< QgsMeshLayer >( uri, QStringLiteral( "test" ), QStringLiteral( "mdal" ) );
+      QVERIFY( ml->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsMeshLayerProperties dialog( ml.get(), &canvas );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testInvalidMeshProperties()
+    {
+      // invalid mesh layer
+      QString uri( mTestDataDir + "/mesh/xxquad_and_triangle.2dm" );
+      std::unique_ptr< QgsMeshLayer > ml = std::make_unique< QgsMeshLayer >( uri, QStringLiteral( "test" ), QStringLiteral( "xmdal" ) );
+      QVERIFY( !ml->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsMeshLayerProperties dialog( ml.get(), &canvas );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testValidPointCloudProperties()
+    {
+      // valid point cloud layer
+      std::unique_ptr< QgsPointCloudLayer > layer = std::make_unique< QgsPointCloudLayer >( mTestDataDir + QStringLiteral( "point_clouds/ept/sunshine-coast/ept.json" ), QStringLiteral( "layer" ), QStringLiteral( "ept" ) );
+      QVERIFY( layer->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsPointCloudLayerProperties dialog( layer.get(), &canvas, &messageBar );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testInvalidPointCloudProperties()
+    {
+      // invalid point cloud layer
+      std::unique_ptr< QgsPointCloudLayer > layer = std::make_unique< QgsPointCloudLayer >( mTestDataDir + QStringLiteral( "xxpoint_clouds/ept/sunshine-coast/ept.json" ), QStringLiteral( "layer" ), QStringLiteral( "xxept" ) );
+      QVERIFY( !layer->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsPointCloudLayerProperties dialog( layer.get(), &canvas, &messageBar );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testValidVectorTileProperties()
+    {
+      // valid vector tile layer
+      const QString srcMbtiles = QStringLiteral( "type=mbtiles&url=%1/vector_tile/mbtiles_vt.mbtiles" ).arg( TEST_DATA_DIR );
+      std::unique_ptr< QgsVectorTileLayer > layer = std::make_unique< QgsVectorTileLayer >( srcMbtiles );
+      QVERIFY( layer->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsVectorTileLayerProperties dialog( layer.get(), &canvas, &messageBar );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testInvalidVectorTileProperties()
+    {
+      // invalid vector tile layer
+      const QString srcMbtiles = QStringLiteral( "type=mbtiles&url=%1/vector_tile/xxmbtiles_vt.mbtiles" ).arg( TEST_DATA_DIR );
+      std::unique_ptr< QgsVectorTileLayer > layer = std::make_unique< QgsVectorTileLayer >( srcMbtiles );
+      QVERIFY( !layer->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsVectorTileLayerProperties dialog( layer.get(), &canvas, &messageBar );
+      dialog.show();
+      dialog.accept();
+    }
+
+    void testValidAnnotationLayerProperties()
+    {
+      // valid annotation layer
+      std::unique_ptr< QgsAnnotationLayer > layer = std::make_unique< QgsAnnotationLayer >( QStringLiteral( "xxx" ), QgsAnnotationLayer::LayerOptions( QgsCoordinateTransformContext() ) );
+      QVERIFY( layer->isValid() );
+
+      QgsMapCanvas canvas;
+      QgsMessageBar messageBar;
+      QgsAnnotationLayerProperties dialog( layer.get(), &canvas, &messageBar );
+      dialog.show();
+      dialog.accept();
+    }
+};
+
+QGSTEST_MAIN( TestQgsLayerPropertiesDialogs )
+#include "testqgslayerpropertiesdialogs.moc"