Navigation Menu

Skip to content

Commit

Permalink
[statistics] In the stats panel, fix hard-coded expression return val…
Browse files Browse the repository at this point in the history
…ue as numerical
  • Loading branch information
nirvn committed Aug 30, 2021
1 parent 5c35b1c commit a3db48a
Showing 1 changed file with 40 additions and 0 deletions.
40 changes: 40 additions & 0 deletions src/app/qgsstatisticalsummarydockwidget.cpp
Expand Up @@ -159,6 +159,46 @@ void QgsStatisticalSummaryDockWidget::refreshStatistics()
{
mFieldType = fieldType( mFieldExpressionWidget->currentField() );
}
else
{
QgsExpressionContext context;
context.appendScopes( QgsExpressionContextUtils::globalProjectLayerScopes( mLayer ) );
QgsExpression expression( mFieldExpressionWidget->expression() );
QgsFeatureRequest request = QgsFeatureRequest();
request.setFlags( ( expression.needsGeometry() ) ?
QgsFeatureRequest::NoFlags :
QgsFeatureRequest::NoGeometry );
request.setLimit( 10 );
request.setExpressionContext( context );


QgsFeature f;
QgsFeatureIterator it = mSelectedOnlyCheckBox->isChecked() ? mLayer->getSelectedFeatures( request ) : mLayer->getFeatures( request );
bool hasFeature = it.nextFeature( f );
while ( hasFeature )
{
context.setFeature( f );
const QVariant v = expression.evaluate( &context );
if ( !v.isNull() )
{
switch ( v.type() )
{
case QVariant::String:
mFieldType = DataType::String;
break;
case QVariant::Date:
case QVariant::DateTime:
mFieldType = DataType::DateTime;
break;
default:
mFieldType = DataType::Numeric;
break;
}
break;
}
hasFeature = it.nextFeature( f );
}
}

if ( mFieldType != mPreviousFieldType )
{
Expand Down

0 comments on commit a3db48a

Please sign in to comment.