Skip to content

Commit

Permalink
Introduced QgsProjectStorage and QgsProjectStorageRegistry
Browse files Browse the repository at this point in the history
This is going to be used as an abstraction of how/where project
files are stored.
  • Loading branch information
wonder-sk committed Apr 7, 2018
1 parent ce72536 commit a30646f
Show file tree
Hide file tree
Showing 15 changed files with 565 additions and 0 deletions.
2 changes: 2 additions & 0 deletions python/core/core_auto.sip
Expand Up @@ -91,6 +91,8 @@
%Include qgsprojectbadlayerhandler.sip
%Include qgsprojectfiletransform.sip
%Include qgsprojectproperty.sip
%Include qgsprojectstorage.sip
%Include qgsprojectstorageregistry.sip
%Include qgsprojectversion.sip
%Include qgsproperty.sip
%Include qgspropertycollection.sip
Expand Down
7 changes: 7 additions & 0 deletions python/core/qgsapplication.sip.in
Expand Up @@ -735,6 +735,13 @@ Returns registry of available 3D renderers.
not available in Python bindings

.. versionadded:: 3.0
%End

static QgsProjectStorageRegistry *projectStorageRegistry();
%Docstring
Returns registry of available project storage implementations.

.. versionadded:: 3.2
%End

static QString nullRepresentation();
Expand Down
64 changes: 64 additions & 0 deletions python/core/qgsprojectstorage.sip.in
@@ -0,0 +1,64 @@
/************************************************************************
* This file has been generated automatically from *
* *
* src/core/qgsprojectstorage.h *
* *
* Do not edit manually ! Edit header and run scripts/sipify.pl again *
************************************************************************/





class QgsProjectStorage
{
%Docstring
Abstract interface for project storage - to be implemented by various backends
and registered in QgsProjectStorageRegistry.

.. versionadded:: 3.2
%End

%TypeHeaderCode
#include "qgsprojectstorage.h"
%End
public:
virtual ~QgsProjectStorage();

virtual QString type() = 0;
%Docstring
Unique identifier of the project storage type. If type() returns "memory", all project file names
starting with "memory:" will have read/write redirected through that storage implementation.
%End

virtual QStringList listProjects( const QString &uri ) = 0;
%Docstring
Returns list of all projects for given URI (specific to each storage backend)
%End

virtual bool readProject( const QString &uri, QIODevice *device, QgsReadWriteContext &context ) = 0;
%Docstring
Reads project file content stored in the backend at the specified URI to the given device
(could be e.g. a temporary file or a memory buffer). The device is expected to be empty
when passed to readProject() so that the method can write all data to it and then rewind
it using seek(0) to make it ready for reading in :py:class:`QgsProject`.
%End

virtual bool writeProject( const QString &uri, QIODevice *device, QgsReadWriteContext &context ) = 0;
%Docstring
Writes project file content stored in given device (could be e.g. a temporary file or a memory buffer)
using the backend to the specified URI. The device is expected to contain all project file data
and having position at the start of the content when passed to writeProject() so that the method
can read all data from it until it reaches its end.
%End


};

/************************************************************************
* This file has been generated automatically from *
* *
* src/core/qgsprojectstorage.h *
* *
* Do not edit manually ! Edit header and run scripts/sipify.pl again *
************************************************************************/
57 changes: 57 additions & 0 deletions python/core/qgsprojectstorageregistry.sip.in
@@ -0,0 +1,57 @@
/************************************************************************
* This file has been generated automatically from *
* *
* src/core/qgsprojectstorageregistry.h *
* *
* Do not edit manually ! Edit header and run scripts/sipify.pl again *
************************************************************************/





class QgsProjectStorageRegistry
{
%Docstring
Registry of storage backends that QgsProject may use.
This is a singleton that should be accessed through :py:func:`QgsApplication.projectStorageRegistry()`

.. versionadded:: 3.2
%End

%TypeHeaderCode
#include "qgsprojectstorageregistry.h"
%End
public:
QgsProjectStorageRegistry();
~QgsProjectStorageRegistry();

QgsProjectStorage *projectStorageFromUri( const QString &uri );
%Docstring
Returns storage implementation if the URI matches one. Returns null pointer otherwise (it is a normal file)
%End

QList<QgsProjectStorage *> projectStorages() const;
%Docstring
Returns a list of registered project storage implementations
%End

void registerProjectStorage( QgsProjectStorage *storage /Transfer/ );
%Docstring
Registers a storage backend and takes ownership of it
%End

void unregisterProjectStorage( QgsProjectStorage *storage );
%Docstring
Unregisters a storage backend and destroys its instance
%End

};

/************************************************************************
* This file has been generated automatically from *
* *
* src/core/qgsprojectstorageregistry.h *
* *
* Do not edit manually ! Edit header and run scripts/sipify.pl again *
************************************************************************/
4 changes: 4 additions & 0 deletions src/core/CMakeLists.txt
Expand Up @@ -259,6 +259,8 @@ SET(QGIS_CORE_SRCS
qgsprojectfiletransform.cpp
qgssnappingconfig.cpp
qgsprojectproperty.cpp
qgsprojectstorage.cpp
qgsprojectstorageregistry.cpp
qgsprojectversion.cpp
qgsproperty.cpp
qgspropertycollection.cpp
Expand Down Expand Up @@ -889,6 +891,8 @@ SET(QGIS_CORE_HDRS
qgsprojectbadlayerhandler.h
qgsprojectfiletransform.h
qgsprojectproperty.h
qgsprojectstorage.h
qgsprojectstorageregistry.h
qgsprojectversion.h
qgsproperty.h
qgsproperty_p.h
Expand Down
8 changes: 8 additions & 0 deletions src/core/qgsapplication.cpp
Expand Up @@ -31,6 +31,7 @@
#include "qgssvgcache.h"
#include "qgscolorschemeregistry.h"
#include "qgspainteffectregistry.h"
#include "qgsprojectstorageregistry.h"
#include "qgsrasterrendererregistry.h"
#include "qgsrendererregistry.h"
#include "qgssymbollayerregistry.h"
Expand Down Expand Up @@ -1710,6 +1711,11 @@ Qgs3DRendererRegistry *QgsApplication::renderer3DRegistry()
return members()->m3DRendererRegistry;
}

QgsProjectStorageRegistry *QgsApplication::projectStorageRegistry()
{
return members()->mProjectStorageRegistry;
}

QgsApplication::ApplicationMembers::ApplicationMembers()
{
// don't use initializer lists or scoped pointers - as more objects are added here we
Expand All @@ -1733,6 +1739,7 @@ QgsApplication::ApplicationMembers::ApplicationMembers()
mLayoutItemRegistry->populate();
mAnnotationRegistry = new QgsAnnotationRegistry();
m3DRendererRegistry = new Qgs3DRendererRegistry();
mProjectStorageRegistry = new QgsProjectStorageRegistry();
}

QgsApplication::ApplicationMembers::~ApplicationMembers()
Expand All @@ -1747,6 +1754,7 @@ QgsApplication::ApplicationMembers::~ApplicationMembers()
delete mPaintEffectRegistry;
delete mPluginLayerRegistry;
delete mProcessingRegistry;
delete mProjectStorageRegistry;
delete mPageSizeRegistry;
delete mLayoutItemRegistry;
delete mProfiler;
Expand Down
8 changes: 8 additions & 0 deletions src/core/qgsapplication.h
Expand Up @@ -30,6 +30,7 @@ class QgsTaskManager;
class QgsFieldFormatterRegistry;
class QgsColorSchemeRegistry;
class QgsPaintEffectRegistry;
class QgsProjectStorageRegistry;
class QgsRendererRegistry;
class QgsSvgCache;
class QgsSymbolLayerRegistry;
Expand Down Expand Up @@ -668,6 +669,12 @@ class CORE_EXPORT QgsApplication : public QApplication
*/
static Qgs3DRendererRegistry *renderer3DRegistry();

/**
* Returns registry of available project storage implementations.
* \since QGIS 3.2
*/
static QgsProjectStorageRegistry *projectStorageRegistry();

/**
* This string is used to represent the value `NULL` throughout QGIS.
*
Expand Down Expand Up @@ -799,6 +806,7 @@ class CORE_EXPORT QgsApplication : public QApplication
QgsPaintEffectRegistry *mPaintEffectRegistry = nullptr;
QgsPluginLayerRegistry *mPluginLayerRegistry = nullptr;
QgsProcessingRegistry *mProcessingRegistry = nullptr;
QgsProjectStorageRegistry *mProjectStorageRegistry = nullptr;
QgsPageSizeRegistry *mPageSizeRegistry = nullptr;
QgsRasterRendererRegistry *mRasterRendererRegistry = nullptr;
QgsRendererRegistry *mRendererRegistry = nullptr;
Expand Down
55 changes: 55 additions & 0 deletions src/core/qgsproject.cpp
Expand Up @@ -29,6 +29,8 @@
#include "qgsprojectfiletransform.h"
#include "qgssnappingconfig.h"
#include "qgspathresolver.h"
#include "qgsprojectstorage.h"
#include "qgsprojectstorageregistry.h"
#include "qgsprojectversion.h"
#include "qgsrasterlayer.h"
#include "qgsreadwritecontext.h"
Expand Down Expand Up @@ -822,6 +824,26 @@ bool QgsProject::read()
QString filename = mFile.fileName();
bool rc;

QgsProjectStorage *storage = QgsApplication::projectStorageRegistry()->projectStorageFromUri( filename );
if ( storage )
{
QTemporaryFile inDevice;
if ( !inDevice.open() )
{
setError( tr( "Unable to open %1" ).arg( inDevice.fileName() ) );
return false;
}

QgsReadWriteContext context;
if ( !storage->readProject( filename, &inDevice, context ) )
{
setError( tr( "Unable to open %1" ).arg( filename ) );
return false;
}

return unzip( inDevice.fileName() ); // calls setError() if returning false
}

if ( QgsZipUtils::isZipFile( mFile.fileName() ) )
{
rc = unzip( mFile.fileName() );
Expand Down Expand Up @@ -1374,6 +1396,39 @@ bool QgsProject::write( const QString &filename )

bool QgsProject::write()
{
QgsProjectStorage *projectStorage = QgsApplication::projectStorageRegistry()->projectStorageFromUri( mFile.fileName() );
if ( projectStorage )
{
// for projects stored in a custom storage, we cannot use relative paths since the storage most likely
// will not be in a file system
writeEntry( QStringLiteral( "Paths" ), QStringLiteral( "/Absolute" ), true );

QString tempPath = QStandardPaths::standardLocations( QStandardPaths::TempLocation ).at( 0 );
QString tmpZipFilename( tempPath + QDir::separator() + QUuid::createUuid().toString() );

if ( !zip( tmpZipFilename ) )
return false; // zip() already calls setError() when returning false

QFile tmpZipFile( tmpZipFilename );
if ( !tmpZipFile.open( QIODevice::ReadOnly ) )
{
setError( tr( "Unable to read file %1" ).arg( tmpZipFilename ) );
return false;
}

QgsReadWriteContext context;
if ( !projectStorage->writeProject( mFile.fileName(), &tmpZipFile, context ) )
{
setError( tr( "Unable to save project to storage %1" ).arg( mFile.fileName() ) );
return false;
}

tmpZipFile.close();
QFile::remove( tmpZipFilename );

return true;
}

if ( QgsZipUtils::isZipFile( mFile.fileName() ) )
{
return zip( mFile.fileName() );
Expand Down
1 change: 1 addition & 0 deletions src/core/qgsproject.h
Expand Up @@ -56,6 +56,7 @@ class QgsMapLayer;
class QgsMapThemeCollection;
class QgsPathResolver;
class QgsProjectBadLayerHandler;
class QgsProjectStorage;
class QgsRelationManager;
class QgsTolerance;
class QgsTransactionGroup;
Expand Down
21 changes: 21 additions & 0 deletions src/core/qgsprojectstorage.cpp
@@ -0,0 +1,21 @@
/***************************************************************************
qgsprojectstorage.cpp
--------------------------------------
Date : March 2018
Copyright : (C) 2018 by Martin Dobias
Email : wonder dot sk at gmail dot com
***************************************************************************
* *
* This program is free software; you can redistribute it and/or modify *
* it under the terms of the GNU General Public License as published by *
* the Free Software Foundation; either version 2 of the License, or *
* (at your option) any later version. *
* *
***************************************************************************/

#include "qgsprojectstorage.h"


QgsProjectStorage::~QgsProjectStorage()
{
}

0 comments on commit a30646f

Please sign in to comment.