Fix doxygen, spelling, shared_ptr

qgis · Mar 31, 2020 · a2f8646 · a2f8646
1 parent be98e2f
commit a2f8646
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/python/core/auto_generated/raster/qgsrastercontourrenderer.sip.in b/python/core/auto_generated/raster/qgsrastercontourrenderer.sip.in
@@ -36,6 +36,9 @@ QgsRasterContourRenderer cannot be copied. Use clone() instead.
 %End
 
     static QgsRasterRenderer *create( const QDomElement &elem, QgsRasterInterface *input ) /Factory/;
+%Docstring
+Creates an instance of the renderer based on definition from XML (used by renderer registry)
+%End
 
     virtual void writeXml( QDomDocument &doc, QDomElement &parentElem ) const;
 
@@ -96,7 +99,7 @@ Sets the symbol of index contour lines
 %Docstring
 Returns by how much the renderer will scale down the request to the data provider.
 For example, for a raster block 1000x500 with downscale 10, the renderer will request raster 100x50 from provider.
-Higher downscale makes contour lines more simplified (at the expense of loosing some detail).
+Higher downscale makes contour lines more simplified (at the expense of losing some detail).
 The value of one means there will be no downscaling.
 %End
 

diff --git a/src/core/raster/qgsrastercontourrenderer.cpp b/src/core/raster/qgsrastercontourrenderer.cpp
@@ -148,7 +148,7 @@ QgsRasterBlock *QgsRasterContourRenderer::block( int bandNo, const QgsRectangle
   int inputWidth = static_cast<int>( round( width / mDownscale ) );
   int inputHeight = static_cast<int>( round( height / mDownscale ) );
 
-  std::shared_ptr< QgsRasterBlock > inputBlock( mInput->block( mInputBand, extent, inputWidth, inputHeight, feedback ) );
+  std::unique_ptr< QgsRasterBlock > inputBlock( mInput->block( mInputBand, extent, inputWidth, inputHeight, feedback ) );
   if ( !inputBlock || inputBlock->isEmpty() )
   {
     QgsDebugMsg( QStringLiteral( "No raster data!" ) );

diff --git a/src/core/raster/qgsrastercontourrenderer.h b/src/core/raster/qgsrastercontourrenderer.h
@@ -41,6 +41,7 @@ class CORE_EXPORT QgsRasterContourRenderer : public QgsRasterRenderer
 
     QgsRasterContourRenderer *clone() const override SIP_FACTORY;
 
+    //! Creates an instance of the renderer based on definition from XML (used by renderer registry)
     static QgsRasterRenderer *create( const QDomElement &elem, QgsRasterInterface *input ) SIP_FACTORY;
 
     void writeXml( QDomDocument &doc, QDomElement &parentElem ) const override;
@@ -79,7 +80,7 @@ class CORE_EXPORT QgsRasterContourRenderer : public QgsRasterRenderer
     /**
      * Returns by how much the renderer will scale down the request to the data provider.
      * For example, for a raster block 1000x500 with downscale 10, the renderer will request raster 100x50 from provider.
-     * Higher downscale makes contour lines more simplified (at the expense of loosing some detail).
+     * Higher downscale makes contour lines more simplified (at the expense of losing some detail).
      * The value of one means there will be no downscaling.
      */
     double downscale() const { return mDownscale; }