Skip to content

Commit a28cd2c

Browse files
uclarosnyalldawson
authored andcommittedJan 18, 2022
Address review
1 parent be99a16 commit a28cd2c

File tree

4 files changed

+12
-5
lines changed

4 files changed

+12
-5
lines changed
 

‎python/core/auto_generated/pointcloud/qgspointcloudrenderer.sip.in

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ Abstract base class for 2d point cloud renderers.
199199

200200
enum DrawOrder
201201
{
202-
Unchanged,
202+
Default,
203203
BottomToTop,
204204
TopToBottom,
205205
};
@@ -378,13 +378,17 @@ Returns the map unit scale used for the point size.
378378
Returns the drawing order used by the renderer for drawing points.
379379

380380
.. seealso:: :py:func:`setDrawOrder2d`
381+
382+
.. versionadded:: 3.24
381383
%End
382384

383385
void setDrawOrder2d( DrawOrder order );
384386
%Docstring
385387
Sets the drawing ``order`` used by the renderer for drawing points.
386388

387389
.. seealso:: :py:func:`drawOrder2d`
390+
391+
.. versionadded:: 3.24
388392
%End
389393

390394
PointSymbol pointSymbol() const;

‎src/core/pointcloud/qgspointcloudlayerrenderer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ bool QgsPointCloudLayerRenderer::render()
190190
nodesDrawn += renderNodesSorted( nodes, pc, context, request, canceled, mRenderer->drawOrder2d() );
191191
break;
192192
}
193-
case QgsPointCloudRenderer::DrawOrder::Unchanged:
193+
case QgsPointCloudRenderer::DrawOrder::Default:
194194
{
195195
if ( pc->accessType() == QgsPointCloudIndex::AccessType::Local )
196196
{

‎src/core/pointcloud/qgspointcloudrenderer.h

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,10 +274,11 @@ class CORE_EXPORT QgsPointCloudRenderer
274274

275275
/**
276276
* Pointcloud rendering order for 2d views
277+
* /since QGIS 3.24
277278
*/
278279
enum DrawOrder
279280
{
280-
Unchanged, //!< Draw points in the order they are stored
281+
Default, //!< Draw points in the order they are stored
281282
BottomToTop, //!< Draw points with larger Z values last
282283
TopToBottom, //!< Draw points with larger Z values first
283284
};
@@ -450,13 +451,15 @@ class CORE_EXPORT QgsPointCloudRenderer
450451
* Returns the drawing order used by the renderer for drawing points.
451452
*
452453
* \see setDrawOrder2d()
454+
* \since QGIS 3.24
453455
*/
454456
DrawOrder drawOrder2d() const;
455457

456458
/**
457459
* Sets the drawing \a order used by the renderer for drawing points.
458460
*
459461
* \see drawOrder2d()
462+
* \since QGIS 3.24
460463
*/
461464
void setDrawOrder2d( DrawOrder order );
462465

@@ -616,7 +619,7 @@ class CORE_EXPORT QgsPointCloudRenderer
616619

617620
PointSymbol mPointSymbol = Square;
618621
int mPainterPenWidth = 1;
619-
DrawOrder mDrawOrder2d = Unchanged;
622+
DrawOrder mDrawOrder2d = DrawOrder::Default;
620623
};
621624

622625
#endif // QGSPOINTCLOUDRENDERER_H

‎src/gui/pointcloud/qgspointcloudrendererpropertieswidget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ QgsPointCloudRendererPropertiesWidget::QgsPointCloudRendererPropertiesWidget( Qg
101101
connect( mPointSizeSpinBox, qOverload<double>( &QgsDoubleSpinBox::valueChanged ), this, &QgsPointCloudRendererPropertiesWidget::emitWidgetChanged );
102102
connect( mPointSizeUnitWidget, &QgsUnitSelectionWidget::changed, this, &QgsPointCloudRendererPropertiesWidget::emitWidgetChanged );
103103

104-
mDrawOrderComboBox->addItem( tr( "Default" ), QgsPointCloudRenderer::DrawOrder::Unchanged );
104+
mDrawOrderComboBox->addItem( tr( "Default" ), QgsPointCloudRenderer::DrawOrder::Default );
105105
mDrawOrderComboBox->addItem( tr( "Bottom to top" ), QgsPointCloudRenderer::DrawOrder::BottomToTop );
106106
mDrawOrderComboBox->addItem( tr( "Top to bottom" ), QgsPointCloudRenderer::DrawOrder::TopToBottom );
107107

0 commit comments

Comments
 (0)
Please sign in to comment.