[FEATURE] When browsing a style from the browser panel, allow copying

nyalldawson · nyalldawson · commit a1b44c939d47 · 2019-01-16T12:04:34.000+11:00
symbols to the default style from the right click menu and share button

Allows users to easily transfer symbols and ramps from a style xml
file directly to their local style database.
diff --git a/src/gui/symbology/qgsstylemanagerdialog.cpp b/src/gui/symbology/qgsstylemanagerdialog.cpp
@@ -203,9 +203,17 @@ QgsStyleManagerDialog::QgsStyleManagerDialog( QgsStyle *style, QWidget *parent,
     shareMenu->addAction( importAction );
     connect( importAction, &QAction::triggered, this, &QgsStyleManagerDialog::importItems );
   }
+  if ( mStyle != QgsStyle::defaultStyle() )
+  {
+    mActionCopyToDefault = new QAction( tr( "Copy Item(s) to Default Style…" ), this );
+    shareMenu->addAction( mActionCopyToDefault );
+    connect( mActionCopyToDefault, &QAction::triggered, this, &QgsStyleManagerDialog::copyItemsToDefault );
+  }
+
   shareMenu->addSeparator();
   shareMenu->addAction( actnExportAsPNG );
   shareMenu->addAction( actnExportAsSVG );
+
   connect( actnExportAsPNG, &QAction::triggered, this, &QgsStyleManagerDialog::exportItemsPNG );
   connect( actnExportAsSVG, &QAction::triggered, this, &QgsStyleManagerDialog::exportItemsSVG );
   connect( exportAction, &QAction::triggered, this, &QgsStyleManagerDialog::exportItems );
@@ -320,6 +328,10 @@ QgsStyleManagerDialog::QgsStyleManagerDialog( QgsStyle *style, QWidget *parent,
     btnAddTag->setVisible( false );
     btnManageGroups->setVisible( false );
   }
+  if ( mActionCopyToDefault )
+  {
+    mGroupMenu->addAction( mActionCopyToDefault );
+  }
   mGroupMenu->addAction( actnExportAsPNG );
   mGroupMenu->addAction( actnExportAsSVG );
 
@@ -410,6 +422,18 @@ void QgsStyleManagerDialog::tabItemType_currentChanged( int )
   populateList();
 }
 
+void QgsStyleManagerDialog::copyItemsToDefault()
+{
+  const QList< ItemDetails > items = selectedItems();
+  if ( !items.empty() )
+  {
+    auto cursorOverride = qgis::make_unique< QgsTemporaryCursorOverride >( Qt::WaitCursor );
+    copyItems( items, mStyle, QgsStyle::defaultStyle(), this, cursorOverride, true, QStringList(), false, false );
+    QMessageBox::information( this, tr( "Import Symbols" ),
+                              tr( "Symbols successfully imported." ) );
+  }
+}
+
 int QgsStyleManagerDialog::selectedItemType()
 {
   QModelIndex index = listItems->selectionModel()->currentIndex();
@@ -1556,6 +1580,8 @@ void QgsStyleManagerDialog::selectedSymbolsChanged( const QItemSelection &select
   actnDetag->setDisabled( nothingSelected || mReadOnly );
   actnExportAsPNG->setDisabled( nothingSelected );
   actnExportAsSVG->setDisabled( nothingSelected );
+  if ( mActionCopyToDefault )
+    mActionCopyToDefault->setDisabled( nothingSelected );
   actnEditItem->setDisabled( nothingSelected || mReadOnly );
 }
 
diff --git a/src/gui/symbology/qgsstylemanagerdialog.h b/src/gui/symbology/qgsstylemanagerdialog.h
@@ -317,6 +317,8 @@ class GUI_EXPORT QgsStyleManagerDialog : public QDialog, private Ui::QgsStyleMan
 
     void tabItemType_currentChanged( int );
 
+    void copyItemsToDefault();
+
   private:
     int selectedItemType();
 
@@ -365,6 +367,8 @@ class GUI_EXPORT QgsStyleManagerDialog : public QDialog, private Ui::QgsStyleMan
     //! Menu for the "Add item" toolbutton when in colorramp mode
     QMenu *mMenuBtnAddItemColorRamp = nullptr;
 
+    QAction *mActionCopyToDefault = nullptr;
+
     int mBlockGroupUpdates = 0;
 
     bool mReadOnly = false;
