Merge pull request #6221 from nyalldawson/var_leak

Fix massive memory leak in PyQGIS, pt 1
qgis · Feb 13, 2018 · a1a4553 · a1a4553
2 parents 0c6f223 + bbf3ed9
commit a1a4553
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/python/core/conversions.sip b/python/core/conversions.sip
@@ -1709,7 +1709,11 @@ bool null_from_qvariant_converter( const QVariant *varp, PyObject **objp )
   {
     sWatchDog = true;
     PyObject *vartype = sipConvertFromEnum( varp->type(), sipType_QVariant_Type );
-    *objp = PyObject_Call(( PyObject * )sipTypeAsPyTypeObject( sipType_QVariant ), PyTuple_Pack( 1, vartype ), nullptr );
+    PyObject *args = PyTuple_Pack( 1, vartype );
+    PyTypeObject *typeObj = sipTypeAsPyTypeObject( sipType_QVariant );
+    *objp = PyObject_Call(( PyObject * )typeObj, args, nullptr );
+    Py_DECREF(args);
+    Py_DECREF(vartype);
     sWatchDog = false;
     return true;
   }