Unit tests for extract binary algorithm

nyalldawson · nyalldawson · commit a192dab9de35 · 2018-11-13T07:14:19.000+10:00
diff --git a/src/analysis/processing/qgsalgorithmextractbinary.cpp b/src/analysis/processing/qgsalgorithmextractbinary.cpp
@@ -32,7 +32,9 @@ QString QgsExtractBinaryFieldAlgorithm::displayName() const
 
 QString QgsExtractBinaryFieldAlgorithm::shortHelpString() const
 {
-  return QObject::tr( "This algorithm extracts contents from a binary field, saving them to individual files." );
+  return QObject::tr( "This algorithm extracts contents from a binary field, saving them to individual files.\n\n"
+                      "Filenames can be generated using data defined values, allowing them to be taken from"
+                      "an attribute in the source table or based on a more complex expression." );
 }
 
 QString QgsExtractBinaryFieldAlgorithm::shortDescription() const
diff --git a/tests/src/analysis/testqgsprocessingalgs.cpp b/tests/src/analysis/testqgsprocessingalgs.cpp
@@ -47,6 +47,7 @@ class TestQgsProcessingAlgs: public QObject
     void transformAlg();
     void kmeansCluster();
     void categorizeByStyle();
+    void extractBinary();
 
   private:
 
@@ -628,6 +629,45 @@ void TestQgsProcessingAlgs::categorizeByStyle()
   QCOMPARE( catRenderer->categories().at( catRenderer->categoryIndexForValue( QStringLiteral( "c " ) ) ).symbol()->color().name(), QStringLiteral( "#0000ff" ) );
 }
 
+void TestQgsProcessingAlgs::extractBinary()
+{
+  std::unique_ptr< QgsProcessingAlgorithm > alg( QgsApplication::processingRegistry()->createAlgorithmById( QStringLiteral( "native:extractbinary" ) ) );
+  QVERIFY( alg != nullptr );
+
+  std::unique_ptr< QgsProcessingContext > context = qgis::make_unique< QgsProcessingContext >();
+  QgsProject p;
+  context->setProject( &p );
+
+  QString dataDir( TEST_DATA_DIR ); //defined in CmakeLists.txt
+  const QString source = dataDir + QStringLiteral( "/attachments.gdb|layername=points__ATTACH" );
+
+
+  QVariantMap parameters;
+  parameters.insert( QStringLiteral( "INPUT" ), source );
+  parameters.insert( QStringLiteral( "FIELD" ), QStringLiteral( "DATA" ) );
+  parameters.insert( QStringLiteral( "FILENAME" ), QgsProperty::fromExpression( QStringLiteral( "'test' || \"ATTACHMENTID\" || '.jpg'" ) ) );
+  const QString folder = QDir::tempPath();
+  parameters.insert( QStringLiteral( "FOLDER" ), folder );
+
+  bool ok = false;
+  QgsProcessingFeedback feedback;
+  QVariantMap results = alg->run( parameters, *context, &feedback, &ok );
+  QVERIFY( ok );
+
+  QCOMPARE( results.count(), 1 );
+  QCOMPARE( results.value( QStringLiteral( "FOLDER" ) ), folder );
+
+  QFile file( folder + "/test1.jpg" );
+  QVERIFY( file.open( QIODevice::ReadOnly ) );
+  QByteArray d = file.readAll();
+  QCOMPARE( QCryptographicHash::hash( d, QCryptographicHash::Md5 ).toHex(), QStringLiteral( "ef3dbc530cc39a545832a6c82aac57b6" ) );
+
+  QFile file2( folder + "/test2.jpg" );
+  QVERIFY( file2.open( QIODevice::ReadOnly ) );
+  d = file2.readAll();
+  QCOMPARE( QCryptographicHash::hash( d, QCryptographicHash::Md5 ).toHex(), QStringLiteral( "4b952b80e4288ca5111be2f6dd5d6809" ) );
+}
+
 
 QGSTEST_MAIN( TestQgsProcessingAlgs )
 #include "testqgsprocessingalgs.moc"

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,9 @@ QString QgsExtractBinaryFieldAlgorithm::displayName() const`
`32`	`32`
`33`	`33`	`QString QgsExtractBinaryFieldAlgorithm::shortHelpString() const`
`34`	`34`	`{`
`35`		`- return QObject::tr( "This algorithm extracts contents from a binary field, saving them to individual files." );`
	`35`	`+ return QObject::tr( "This algorithm extracts contents from a binary field, saving them to individual files.\n\n"`
	`36`	`+ "Filenames can be generated using data defined values, allowing them to be taken from"`
	`37`	`+ "an attribute in the source table or based on a more complex expression." );`
`36`	`38`	`}`
`37`	`39`
`38`	`40`	`QString QgsExtractBinaryFieldAlgorithm::shortDescription() const`