[layouts] Fix messagebar link with special characters does not open on win

nyalldawson · nyalldawson · commit a0dceb1d835a · 2018-09-17T11:39:45.000+10:00
Fixes #19727
diff --git a/src/native/win/qgswinnative.cpp b/src/native/win/qgswinnative.cpp
@@ -68,12 +68,19 @@ void QgsWinNative::cleanup()
 void QgsWinNative::openFileExplorerAndSelectFile( const QString &path )
 {
   const QString nativePath = QDir::toNativeSeparators( path );
-  ITEMIDLIST *pidl = ILCreateFromPath( nativePath.toUtf8().constData() );
+
+  wchar_t *pathArray = new wchar_t[static_cast< uint>( nativePath.length() + 1 )];
+  nativePath.toWCharArray(pathArray);
+  pathArray[nativePath.length()] = 0;
+
+  ITEMIDLIST *pidl = ILCreateFromPathW( pathArray );
   if ( pidl )
   {
-    SHOpenFolderAndSelectItems( pidl, 0, 0, 0 );
+    SHOpenFolderAndSelectItems( pidl, 0, nullptr, 0 );
     ILFree( pidl );
   }
+
+  delete[] pathArray;
 }
 
 void QgsWinNative::showUndefinedApplicationProgress()

Original file line number	Diff line number	Diff line change
`@@ -68,12 +68,19 @@ void QgsWinNative::cleanup()`
`68`	`68`	`void QgsWinNative::openFileExplorerAndSelectFile( const QString &path )`
`69`	`69`	`{`
`70`	`70`	`const QString nativePath = QDir::toNativeSeparators( path );`
`71`		`- ITEMIDLIST *pidl = ILCreateFromPath( nativePath.toUtf8().constData() );`
	`71`	`+`
	`72`	`+ wchar_t *pathArray = new wchar_t[static_cast< uint>( nativePath.length() + 1 )];`
	`73`	`+ nativePath.toWCharArray(pathArray);`
	`74`	`+ pathArray[nativePath.length()] = 0;`
	`75`	`+`
	`76`	`+ ITEMIDLIST *pidl = ILCreateFromPathW( pathArray );`
`72`	`77`	`if ( pidl )`
`73`	`78`	`{`
`74`		`- SHOpenFolderAndSelectItems( pidl, 0, 0, 0 );`
	`79`	`+ SHOpenFolderAndSelectItems( pidl, 0, nullptr, 0 );`
`75`	`80`	`ILFree( pidl );`
`76`	`81`	`}`
	`82`	`+`
	`83`	`+ delete[] pathArray;`
`77`	`84`	`}`
`78`	`85`
`79`	`86`	`void QgsWinNative::showUndefinedApplicationProgress()`