SIP: fix typemap for QVector<Type*> that was wrongly dropping a Python reference (refs #19885)

rouault · rouault · commit 9e9ddb587e13 · 2018-09-21T15:31:28.000+02:00
diff --git a/python/core/conversions.sip b/python/core/conversions.sip
@@ -1457,15 +1457,10 @@ template <TYPE>
 
         if (tobj == NULL || PyList_SetItem(l, i, tobj) < 0)
         {
+            Py_DECREF(tobj);
             Py_DECREF(l);
-
-            if (!tobj)
-                delete t;
-
             return NULL;
         }
-
-        Py_DECREF(tobj);
     }
 
     return l;

Original file line number	Diff line number	Diff line change
`@@ -1457,15 +1457,10 @@ template <TYPE>`
`1457`	`1457`
`1458`	`1458`	`if (tobj == NULL \|\| PyList_SetItem(l, i, tobj) < 0)`
`1459`	`1459`	`{`
	`1460`	`+ Py_DECREF(tobj);`
`1460`	`1461`	`Py_DECREF(l);`
`1461`		`-`
`1462`		`- if (!tobj)`
`1463`		`- delete t;`
`1464`		`-`
`1465`	`1462`	`return NULL;`
`1466`	`1463`	`}`
`1467`		`-`
`1468`		`- Py_DECREF(tobj);`
`1469`	`1464`	`}`
`1470`	`1465`
`1471`	`1466`	`return l;`