Fixed dropping PostgreSQL materialized views.

espinafre · nyalldawson · commit 9bc7d4c90cf3 · 2020-05-08T09:48:01.000+10:00
By default, the PostgreSQL provider allows the user to drop database objects from the Browser tree; however, the PostgreSQL syntax for dropping materialized views is different from dropping ordinary views. This fixes it, and adds the keyword "MATERIALIZED" accordingly. Fixes #36164
diff --git a/src/providers/postgres/qgspostgresdataitems.cpp b/src/providers/postgres/qgspostgresdataitems.cpp
@@ -59,7 +59,7 @@ bool QgsPostgresUtils::deleteLayer( const QString &uri, QString &errCause )
   QString type = resViewCheck.PQgetvalue( 0, 0 );
   if ( type == QLatin1String( "v" ) || type == QLatin1String( "m" ) )
   {
-    QString sql = QString( "DROP VIEW %1" ).arg( schemaTableName );
+    QString sql = QString( "DROP %1VIEW %2" ).arg( type == QLatin1String( "m" ) ? "MATERIALIZED " : QString(), schemaTableName );
     QgsPostgresResult result( conn->PQexec( sql ) );
     if ( result.PQresultStatus() != PGRES_COMMAND_OK )
     {

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ bool QgsPostgresUtils::deleteLayer( const QString &uri, QString &errCause )`
`59`	`59`	`QString type = resViewCheck.PQgetvalue( 0, 0 );`
`60`	`60`	`if ( type == QLatin1String( "v" ) \|\| type == QLatin1String( "m" ) )`
`61`	`61`	`{`
`62`		`- QString sql = QString( "DROP VIEW %1" ).arg( schemaTableName );`
	`62`	`+ QString sql = QString( "DROP %1VIEW %2" ).arg( type == QLatin1String( "m" ) ? "MATERIALIZED " : QString(), schemaTableName );`
`63`	`63`	`QgsPostgresResult result( conn->PQexec( sql ) );`
`64`	`64`	`if ( result.PQresultStatus() != PGRES_COMMAND_OK )`
`65`	`65`	`{`