[processing] Simplify algorithm should not run validity checks on geometries

nyalldawson · nyalldawson · commit 9b6367fc1f9f · 2019-02-09T06:24:12.000+10:00
Simplify (by its intrinsic nature) can output invalid geometries,
and its processing is not affected by the presence of input
geometry validity.

Also tag a few other algorithms which aren't sensitive to input
geometry validity.
diff --git a/src/analysis/processing/qgsalgorithmsimplify.cpp b/src/analysis/processing/qgsalgorithmsimplify.cpp
@@ -132,6 +132,11 @@ QgsFeatureList QgsSimplifyAlgorithm::processFeature( const QgsFeature &feature,
   return QgsFeatureList() << f;
 }
 
+QgsProcessingFeatureSource::Flag QgsSimplifyAlgorithm::sourceFlags() const
+{
+  return QgsProcessingFeatureSource::FlagSkipGeometryValidityChecks;
+}
+
 ///@endcond
 
 
diff --git a/src/analysis/processing/qgsalgorithmsimplify.h b/src/analysis/processing/qgsalgorithmsimplify.h
@@ -52,7 +52,7 @@ class QgsSimplifyAlgorithm : public QgsProcessingFeatureBasedAlgorithm
     QString outputName() const override;
     bool prepareAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback ) override;
     QgsFeatureList processFeature( const QgsFeature &feature,  QgsProcessingContext &, QgsProcessingFeedback *feedback ) override;
-
+    QgsProcessingFeatureSource::Flag sourceFlags() const override;
   private:
 
     double mTolerance = 1.0;
diff --git a/src/analysis/processing/qgsalgorithmsmooth.cpp b/src/analysis/processing/qgsalgorithmsmooth.cpp
@@ -156,6 +156,11 @@ QgsFeatureList QgsSmoothAlgorithm::processFeature( const QgsFeature &feature, Qg
   return QgsFeatureList() << f;
 }
 
+QgsProcessingFeatureSource::Flag QgsSmoothAlgorithm::sourceFlags() const
+{
+  return QgsProcessingFeatureSource::FlagSkipGeometryValidityChecks;
+}
+
 ///@endcond
 
 
diff --git a/src/analysis/processing/qgsalgorithmsmooth.h b/src/analysis/processing/qgsalgorithmsmooth.h
@@ -49,6 +49,7 @@ class QgsSmoothAlgorithm : public QgsProcessingFeatureBasedAlgorithm
     QgsProcessing::SourceType outputLayerType() const override;
     bool prepareAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback ) override;
     QgsFeatureList processFeature( const QgsFeature &feature,  QgsProcessingContext &context, QgsProcessingFeedback *feedback ) override;
+    QgsProcessingFeatureSource::Flag sourceFlags() const override;
 
   private:
     int mIterations = 1;
diff --git a/src/analysis/processing/qgsalgorithmsnaptogrid.cpp b/src/analysis/processing/qgsalgorithmsnaptogrid.cpp
@@ -154,6 +154,11 @@ QgsFeatureList QgsSnapToGridAlgorithm::processFeature( const QgsFeature &feature
   return QgsFeatureList() << f;
 }
 
+QgsProcessingFeatureSource::Flag QgsSnapToGridAlgorithm::sourceFlags() const
+{
+  return QgsProcessingFeatureSource::FlagSkipGeometryValidityChecks;
+}
+
 ///@endcond
 
 
diff --git a/src/analysis/processing/qgsalgorithmsnaptogrid.h b/src/analysis/processing/qgsalgorithmsnaptogrid.h
@@ -47,6 +47,7 @@ class QgsSnapToGridAlgorithm : public QgsProcessingFeatureBasedAlgorithm
     QString outputName() const override;
     bool prepareAlgorithm( const QVariantMap &parameters, QgsProcessingContext &context, QgsProcessingFeedback *feedback ) override;
     QgsFeatureList processFeature( const QgsFeature &feature,  QgsProcessingContext &context, QgsProcessingFeedback *feedback ) override;
+    QgsProcessingFeatureSource::Flag sourceFlags() const override;
 
   private:
     double mIntervalX = 0.0;
diff --git a/src/analysis/processing/qgsalgorithmsplitlinesbylength.cpp b/src/analysis/processing/qgsalgorithmsplitlinesbylength.cpp
@@ -144,6 +144,11 @@ QgsFeatureList QgsSplitLinesByLengthAlgorithm::processFeature( const QgsFeature
   }
 }
 
+QgsProcessingFeatureSource::Flag QgsSplitLinesByLengthAlgorithm::sourceFlags() const
+{
+  return QgsProcessingFeatureSource::FlagSkipGeometryValidityChecks;
+}
+
 
 ///@endcond
 
diff --git a/src/analysis/processing/qgsalgorithmsplitlinesbylength.h b/src/analysis/processing/qgsalgorithmsplitlinesbylength.h
@@ -51,6 +51,7 @@ class QgsSplitLinesByLengthAlgorithm : public QgsProcessingFeatureBasedAlgorithm
     QString outputName() const override;
     QgsWkbTypes::Type outputWkbType( QgsWkbTypes::Type inputWkbType ) const override;
     QgsFeatureList processFeature( const QgsFeature &feature,  QgsProcessingContext &context, QgsProcessingFeedback *feedback ) override;
+    QgsProcessingFeatureSource::Flag sourceFlags() const override;
 
   private:
 

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,11 @@ QgsFeatureList QgsSimplifyAlgorithm::processFeature( const QgsFeature &feature,`
`132`	`132`	`return QgsFeatureList() << f;`
`133`	`133`	`}`
`134`	`134`
	`135`	`+QgsProcessingFeatureSource::Flag QgsSimplifyAlgorithm::sourceFlags() const`
	`136`	`+{`
	`137`	`+ return QgsProcessingFeatureSource::FlagSkipGeometryValidityChecks;`
	`138`	`+}`
	`139`	`+`
`135`	`140`	`///@endcond`
`136`	`141`
`137`	`142`
Original file line number	Diff line number	Diff line change
`@@ -156,6 +156,11 @@ QgsFeatureList QgsSmoothAlgorithm::processFeature( const QgsFeature &feature, Qg`
`156`	`156`	`return QgsFeatureList() << f;`
`157`	`157`	`}`
`158`	`158`
	`159`	`+QgsProcessingFeatureSource::Flag QgsSmoothAlgorithm::sourceFlags() const`
	`160`	`+{`
	`161`	`+ return QgsProcessingFeatureSource::FlagSkipGeometryValidityChecks;`
	`162`	`+}`
	`163`	`+`
`159`	`164`	`///@endcond`
`160`	`165`
`161`	`166`
Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,11 @@ QgsFeatureList QgsSnapToGridAlgorithm::processFeature( const QgsFeature &feature`
`154`	`154`	`return QgsFeatureList() << f;`
`155`	`155`	`}`
`156`	`156`
	`157`	`+QgsProcessingFeatureSource::Flag QgsSnapToGridAlgorithm::sourceFlags() const`
	`158`	`+{`
	`159`	`+ return QgsProcessingFeatureSource::FlagSkipGeometryValidityChecks;`
	`160`	`+}`
	`161`	`+`
`157`	`162`	`///@endcond`
`158`	`163`
`159`	`164`
Original file line number	Diff line number	Diff line change
`@@ -144,6 +144,11 @@ QgsFeatureList QgsSplitLinesByLengthAlgorithm::processFeature( const QgsFeature`
`144`	`144`	`}`
`145`	`145`	`}`
`146`	`146`
	`147`	`+QgsProcessingFeatureSource::Flag QgsSplitLinesByLengthAlgorithm::sourceFlags() const`
	`148`	`+{`
	`149`	`+ return QgsProcessingFeatureSource::FlagSkipGeometryValidityChecks;`
	`150`	`+}`
	`151`	`+`
`147`	`152`
`148`	`153`	`///@endcond`
`149`	`154`