QgsVectorLayer::writeSymbology(): fix crash when called with invalid …

…data provider
qgis · Oct 25, 2016 · 9ae1569 · 9ae1569
1 parent a70d428
commit 9ae1569
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/core/qgsvectorlayer.cpp b/src/core/qgsvectorlayer.cpp
@@ -1947,7 +1947,14 @@ bool QgsVectorLayer::writeSymbology( QDomNode& node, QDomDocument& doc, QString&
   mConditionalStyles->writeXml( node, doc );
 
   // save expression fields
-  mExpressionFieldBuffer->writeXml( node, doc );
+  if ( !mExpressionFieldBuffer )
+  {
+    // can happen when saving style on a invalid layer
+    QgsExpressionFieldBuffer dummy;
+    dummy.writeXml( node, doc );
+  }
+  else
+    mExpressionFieldBuffer->writeXml( node, doc );
 
   // save readonly state
   node.toElement().setAttribute( QStringLiteral( "readOnly" ), mReadOnly );